Skip to content

Make Data-model full-bleed OWOX (retire plan-id ModelView chrome) #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Travis-Gilbert wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make Data-model full-bleed OWOX (retire plan-id ModelView chrome) #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/console/e2e/console-sidebar.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,9 @@ test.describe('Console sidebar', () => {
await expect(page.getByTestId('model-canvas-shell')).toBeVisible({
timeout: 120_000,
});
await expect(page.locator('[data-model-inspector]')).toHaveCSS('width', '320px');
// Full-bleed OWOX body: no plan-id inspector rail; canvas fills the well.
await expect(page.locator('[data-model-inspector]')).toHaveCount(0);
await expect(page.locator('[data-model-canvas-page]')).toBeVisible();
});

test('Program route mounts the canonical Program Canvas surface', async ({ page }) => {
Expand Down
4 changes: 2 additions & 2 deletions apps/console/src/app/Data-model/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SOURCING: none. Canonical App Router segment for the Data model surface.
// Server-stamp the register impl so the cutover doctor can observe it without
// waiting for client hydration of ModelView / ForkDiagramCanvas.
// Server-stamp the register impl for the cutover doctor. The page body is the
// console surface with model.studio → ModelCanvasShell (OWOX) full-bleed.

import ConsoleSurfacePage from '@/lib/console-surface-page';

Expand Down
Loading
Loading