ci: replace npm-publish.yml with a working lerna-aware implementation - #839
Merged
Merged
Conversation
The previous npm-publish.yml called tradeshift/actions-workflow-npm's generic single-package reusable workflow, which published nothing useful in this 45-package lerna monorepo (root package.json isn't one of the published @Tradeshift/elements.* packages). Same 'npm publish' comment trigger and OWNER/MEMBER guard as before, now backed by a real lerna-aware implementation. See README.md ("How to test a PR before it's merged") for usage.
5 tasks
|
| Commit | Scanned at | New | Resolved | Net |
|---|---|---|---|---|
6fb6eb8 < |
2026-08-20 07:01 UTC | 0 | 0 | 0 |
Last scanned: 6fb6eb8 · 2026-08-20 07:01 UTC
|
| Commit | Scanned at | New | Resolved | Net |
|---|---|---|---|---|
6fb6eb8 |
2026-08-20 07:01 UTC | — | — | — |
6fb6eb8 < |
2026-08-20 07:01 UTC | 0 | 0 | 0 |
Last scanned: 6fb6eb8 · 2026-08-20 07:01 UTC
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage
MirelaPaun
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This replaces it with a real implementation, same
npm publishcomment trigger andOWNER/MEMBERauthor_associationguard as before. Usage is documented inREADME.md("How to test a PR before it's merged"):npm publish(no argument) →lerna version <explicit-version>bumps every package to the same version regardless of individual change status (matching this repo's fixed/lockstep versioning) and automatically rewrites@tradeshift/elements.*dependency ranges between the packages being published (verified locally: bumping to an explicit version updatedheader's dependency onapp-iconto match) — thenlerna publish from-packageactually publishes them, all under GitHub Packages with thepr-previewdist-tag.npm publish <name>→ publishes just one package (e.g.npm publish app-icon→@tradeshift/elements.app-icon,npm publish core/elements→@tradeshift/elements) as a manual override, via a directnpm version+npm publishin that package's directory. Doesn't rewrite that package's own dependency ranges, so only makes sense when nothing it depends on changed, or those are published separately too.0.0.0-<run_id>, matching the0.0.0-<sha>convention used by other Tradeshift repos' npm-publish workflows (swapping ingithub.run_idinstead of the commit sha specifically so re-runningnpm publishon the same commit — e.g. retrying after a transient failure — gets a distinct version instead of colliding with the previous attempt).lerna ls --json) for the all-packages case, with the exactnpm install ... --registry=https://npm.pkg.github.comcommand to try it.Confirmed downstream Renovate configs (e.g.
Apps, viaTradeshift/renovate-config) have noignoreUnstable/followTagsettings that would pick up these0.0.0--prerelease, non-latest-dist-tag versions.Testing this before merge
issue_comment(like most non-push/pull_requesttriggers) only runs the workflow file version that's on the repo's default branch — commenting on this PR won't exercise the new file until it's merged.Test plan
actions/github-scriptJS syntax checked locally (js-yaml+node --check,${{ }}expressions substituted with placeholders)npm publish,npm publish app-icon,npm publish core/elements, unknown package name, extra whitespace) tested locally against the bash snippet — all resolve correctlylerna version <explicit-version> --no-push --no-git-tag-version --yesrun for real locally against this repo, confirmed it bumps all 45 packages and rewrites cross-package@tradeshift/elements.*dependency ranges, then reverted (did not publish)npm version --no-git-tag-version <explicit-version>(single-package path) run for real againstpackages/components/app-iconlocally, confirmed valid semver output, then revertedlerna publish, PR comment round-trip) — needs to land onmasterfirst, per the note above