fix(ci): guard npm-publish job to skip unrelated PR comments - #836
Closed
jinglongchenTS wants to merge 1 commit into
Closed
fix(ci): guard npm-publish job to skip unrelated PR comments#836jinglongchenTS wants to merge 1 commit into
jinglongchenTS wants to merge 1 commit into
Conversation
Any comment on a PR (including automated bot comments) was queuing the self-hosted npm-publish job before its internal if-condition could skip it. Since elements is a public repo, the org's actions-autoscaler policy blocks self-hosted runners here and cancels the queued job with action_required, showing as a spurious failed check. Move the guard to the calling job so unrelated comments never queue it in the first place. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions-autoscaler, conclusionaction_required: "self-hosted runners are not available on public repositories")..github/workflows/npm-publish.ymllistens to everyissue_commenton a PR with no top-level filter. The reusable workflow it calls (tradeshift/actions-workflow-npm/.github/workflows/comment-npm-publish.yml@v1) hardcodesruns-on: [self-hosted, ts-large-x64-docker-large]and only skips via an internal jobif:(comment body must be exactlynpm publishfrom an OWNER/MEMBER). In this case ats-sonarqube[bot]quality-gate comment on PR chore(deps): update dependency postcss to ^8.5.26 #835 triggered it. Sinceelementsis a public repo, the org's actions-autoscaler policy blocks self-hosted runners here and cancels the job at queue time — before the internalif:can skip it — surfacing as a spurious failed check on unrelated comments.Test plan
npm-publishcheck is queued/red.npm publishon a PR as an org member and confirm the publish job still runs as before.