fix(ui): render workspace terminal with Canvas + CJK fonts#253
Open
maxx-masa wants to merge 1 commit into
Open
fix(ui): render workspace terminal with Canvas + CJK fonts#253maxx-masa wants to merge 1 commit into
maxx-masa wants to merge 1 commit into
Conversation
Switch the xterm renderer from WebGL to Canvas (@xterm/addon-canvas) and add "Noto Sans Mono CJK JP" / "Noto Sans CJK JP" to the terminal font stack so Japanese text renders correctly in workspace sessions. The WebGL glyph atlas drew any styled CJK cell it could not rasterize (notably italic Japanese — Noto Sans Mono CJK JP has no italic face) as a solid black box. The Canvas renderer rasterizes each cell via 2D fillText, falling back through the browser font stack and synthesizing obliques, so bold/italic Japanese renders correctly — while staying much faster than the DOM renderer. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@maxx-masa is attempting to deploy a commit to the luokerenx4's Team Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@xterm/addon-canvas) and addNoto Sans Mono CJK JP/Noto Sans CJK JPto the font stack.fillText, falling back through the browser font stack and synthesizing obliques, so bold/italic Japanese renders correctly — while staying much faster than the DOM renderer.Test plan
cd ui && npx tsc -b— not run locally: node_modules is out of sync with this branch's base (fork base = current upstream), and a full install would disrupt the local dev environment. The change is a minimal, standard renderer swap.Boundary touch
None.
🤖 Generated with Claude Code