Update framework and Modernize setup#3
Draft
Avasam wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize project, build, and tooling
Project / build
.csproj; retarget .NET Framework 4.6.1 → 4.8.1 (matches the LiveSplit host).UseWindowsForms; drop legacy ClickOnce/bootstrapper cruft and explicitCompile/EmbeddedResourceitems (SDK globbing).LiveSplit.exe,LiveSplit.Core.dll,UpdateManager.dll) underlib/withPrivate=false, replacing hardcoded absoluteHintPaths. Addedlib/README.mdwith refresh instructions (pinned to LiveSplit 1.8.37).Properties/AssemblyInfo.cs.packages.lock.jsonfor reproducible restores.Solution / versioning
.slnwith.slnx, then drop it entirely (single-project repo builds fine from the.csprojunder both VS 2022 and the dotnet CLI).<Version>;AssemblyVersion/FileVersionderive from it and the factory reads it at runtime.Auto-updater
KaDiWa4repo toToufool/LiveSplit.AutoSplitIntegration@main.update.xmlentry.CI / tooling
windows-2022, .NET SDK 10, build +dotnet formatcheck, upload DLL artifact)..editorconfig,.vscode/), remove custom.gitattributesoverrides, and trim.gitignorefrom ~248 lines of boilerplate to project-relevant entries.Docs
dotnet buildor VS 2022) and add a "Releasing a new version" section.LLM/Coding agent used back-and-forth to massively speed up the process and analyze through the cruft. Leaving as draft until I properly finish reviewing all the text changes and "humanize" PR description in my own words. Code and config changes already fully human reviewed.