Add German localization and Hope & Fear SRD 2.0 content - #31
Open
TheMBeat wants to merge 11 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds German localization support to DaggerForge and updates the bundled game data with the SRD 2.0 / Hope & Fear content.
The localization started with the character creation flow, but while working through it I found that several parts of the plugin still depended on older or incomplete SRD data. The scope therefore grew a bit to include the missing Hope & Fear content as well as the UI needed to actually use it.
What’s included
The English SRD data remains the canonical source for mechanical values. German content is applied as a localization layer, using stable IDs so changing the display language does not affect saved character references.
Translation
Where an official German Core translation was available, I used its terminology as the reference. Hope & Fear terms were translated to stay consistent with the terminology already established by the German Core material.
I also went through the imported texts manually to fix a number of issues that are easy to miss with extracted or converted source material, such as missing effects, damage values, Stress costs and formatting.
Checks
I added a localization audit to catch common leftover English UI/rules text and extraction artifacts.
There are also regression tests covering a few translations where accidentally dropping part of a sentence would change the actual rule, as well as checks to make sure localized data keeps the same IDs and mechanical values as the English source.
English remains available and should behave as before.