Repository navigation
Tighten network and import handling, correct the privacy text - #6
Merged
Merged
Conversation
The allowlist took the host by splitting on '/', so https://evil.example?.wago.io/a.png passed. It now parses the URL. Catalogue icons had no host limit at all, and the catalogue is read live at launch, so they now use the same list, in the app and in the validator.
Download URLs from the WoWInterface and TukUI APIs were used as returned, and redirects could downgrade to http. Every URL those APIs return for the catalogue is https today, so nothing should break. reqwest keeps custom headers on cross-host redirects, so x-api-key would follow a redirect off api.curseforge.com. That redirect is now an error.
The install plan put a list's source id into innerHTML unescaped. Sources from a list now pass the same checks as a typed repo, and a list can't install a different repo under a catalogue addon's key.
The host list missed the preview image hosts, 'one request at launch' undercounted, the report flow reached GitHub before 'send', and CurseForge data does reach disk. CurseForge download links no longer go in the log. CONTRIBUTING no longer says the exe has no API key.
l3gitpanda
referenced
this pull request
in l3gitpanda/addonforge
Nov 12, 2026
The app, README and build files now point at l3gitpanda/addonforge instead of the original project, and drop its contact details. - Catalogue, stats, User-Agent, REPO_URL and RELEASES_URL use the fork. - Remove SUPPORT_EMAIL and the Report on GitHub / Email buttons (issues are off on the fork); Copy diagnostics stays and sends nothing. - Remove the Discord and Ko-fi links and "by Pocket Forge Studios". - App identifier com.l3gitpanda.addonforge; author and publisher l3gitpanda. The stats workflow commits as github-actions[bot]. - README rewritten as a private build. LICENSE keeps the original MIT notice, as the licence requires, and adds one for the changes. - Roadmap fork-identity table updated (#2, #3, #6 done; #4, #5 partly). cargo test: 110 passed, 2 ignored. security-check, test-ui and validate-catalog OK. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to run AddonForge on my Mac, so I read through the code first. It held up well: I found no ads, analytics or accounts, and the update signing checks out. These are the fixes for the smaller things I did find. Each commit stands alone, so take what you like.
What's in here
Image hosts. The allowlist took the host by splitting on
/, sohttps://evil.example?.wago.io/a.pngpassed. It parses the URL now. Catalogueiconvalues had no host limit at all, and the catalogue is read live at launch, so one entry could make every client fetch any URL. No entry usesicontoday. It now follows the same list, in the app and invalidate-catalog.js.HTTPS on every request. WoWInterface and TukUI download URLs were used as returned, and a redirect could drop to http. All 22 WoWInterface URLs in the catalogue and the TukUI one were https when I checked, so nothing should break.
CurseForge key on redirects. reqwest strips
Authorizationon a cross-host redirect but keeps custom headers, sox-api-keywould follow one offapi.curseforge.com. That's an error now.Imported lists. The install plan put a list's source id into
innerHTMLunescaped (renderImportPlan). The CSP should stop scripts, but markup got through. List sources now pass the same checks as a typed repo, and a list can't install another repo under a catalogue addon's key.More refused file types.
.pyw,.url,.chm,.msc,.msixand a few others got past the zip check. I ran the new entries against the latest release zips of 91 catalogue addons (27,075 files) and they refuse nothing.Privacy text. The README and About panel didn't quite match the code, so I changed them:
latest.json's download counter works as a rough launch count. Cut it if you disagree, but I'd rather users read it from you.Smaller ones.
rustlsgoes to 0.23.46 for the advisories fixed there,security-check.mjsnow runs in CI, andCONTRIBUTING.mdno longer says the exe has no CurseForge key.Left for you
These are your call, so I didn't touch them:
mainreaches every client at next launch. It would need your release key.stats.ymlhas write access to the branch that serves the catalogue.One behaviour change
--cli selfcheck <url>andADDONFORGE_UPDATE_URLnow refuse plainhttp://, so testing updates against a local http server won't work any more.Testing
Rebased on
mainat177f5ee. The workflows here are waiting for your approval, so I ran them on my fork against the same base.cargo test: 86 pass, up from 82, on bothwindows-latestandmacos-latest. The UI and security checks passed there too.validate-catalog.jspasses.--cli resolve allon my Mac: 94 of 103 entries resolve across GitHub, TukUI and WoWInterface, and the other 9 are link-only. The signed update check still passes.