Skip to content

Tighten network and import handling, correct the privacy text - #6

Merged
Topher121 merged 7 commits into
Topher121:mainfrom
sathran:audit-fixes
Nov 6, 2026
Merged

Topher121 merged 7 commits into
Topher121:mainfrom
sathran:audit-fixes

Conversation

@sathran

@sathran sathran commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

I want to run AddonForge on my Mac, so I read through the code first. It held up well: I found no ads, analytics or accounts, and the update signing checks out. These are the fixes for the smaller things I did find. Each commit stands alone, so take what you like.

What's in here

Image hosts. The allowlist took the host by splitting on /, so https://evil.example?.wago.io/a.png passed. It parses the URL now. Catalogue icon values had no host limit at all, and the catalogue is read live at launch, so one entry could make every client fetch any URL. No entry uses icon today. It now follows the same list, in the app and in validate-catalog.js.

HTTPS on every request. WoWInterface and TukUI download URLs were used as returned, and a redirect could drop to http. All 22 WoWInterface URLs in the catalogue and the TukUI one were https when I checked, so nothing should break.

CurseForge key on redirects. reqwest strips Authorization on a cross-host redirect but keeps custom headers, so x-api-key would follow one off api.curseforge.com. That's an error now.

Imported lists. The install plan put a list's source id into innerHTML unescaped (renderImportPlan). The CSP should stop scripts, but markup got through. List sources now pass the same checks as a typed repo, and a list can't install another repo under a catalogue addon's key.

More refused file types. .pyw, .url, .chm, .msc, .msix and a few others got past the zip check. I ran the new entries against the latest release zips of 91 catalogue addons (27,075 files) and they refuse nothing.

Privacy text. The README and About panel didn't quite match the code, so I changed them:

  • The host list was missing the preview image hosts.
  • "One request at launch" is really several.
  • The GitHub report reaches GitHub when the page opens, before you submit.
  • The CurseForge version name does reach disk, in settings and the log. I took download links out of the log and reworded the claim. You know their terms better than I do, so please check that wording.
  • I also added that latest.json's download counter works as a rough launch count. Cut it if you disagree, but I'd rather users read it from you.

Smaller ones. rustls goes to 0.23.46 for the advisories fixed there, security-check.mjs now runs in CI, and CONTRIBUTING.md no longer says the exe has no CurseForge key.

Left for you

These are your call, so I didn't touch them:

  • Signing the catalogue. App updates are signed but the catalogue isn't, and a change on main reaches every client at next launch. It would need your release key.
  • Checking addon zip hashes. Downloads rely on TLS alone.
  • Protecting hand-installed addons. A zip can replace an unmanaged folder and the old copy is deleted. Blocking that would also stop people moving a hand-installed addon to managed.
  • Pinning actions by SHA. stats.yml has write access to the branch that serves the catalogue.

One behaviour change

--cli selfcheck <url> and ADDONFORGE_UPDATE_URL now refuse plain http://, so testing updates against a local http server won't work any more.

Testing

Rebased on main at 177f5ee. The workflows here are waiting for your approval, so I ran them on my fork against the same base.

  • cargo test: 86 pass, up from 82, on both windows-latest and macos-latest. The UI and security checks passed there too.
  • validate-catalog.js passes.
  • --cli resolve all on my Mac: 94 of 103 entries resolve across GitHub, TukUI and WoWInterface, and the other 9 are link-only. The signed update check still passes.
  • Not tested: CurseForge calls (my build has no key) and a release build on a real Windows PC.

The allowlist took the host by splitting on '/', so
https://evil.example?.wago.io/a.png passed. It now parses the URL.
Catalogue icons had no host limit at all, and the catalogue is read live
at launch, so they now use the same list, in the app and in the validator.
Download URLs from the WoWInterface and TukUI APIs were used as returned, and
redirects could downgrade to http. Every URL those APIs return for the catalogue
is https today, so nothing should break.

reqwest keeps custom headers on cross-host redirects, so x-api-key would follow
a redirect off api.curseforge.com. That redirect is now an error.
The install plan put a list's source id into innerHTML unescaped. Sources from
a list now pass the same checks as a typed repo, and a list can't install a
different repo under a catalogue addon's key.
The host list missed the preview image hosts, 'one request at launch' undercounted,
the report flow reached GitHub before 'send', and CurseForge data does reach disk.
CurseForge download links no longer go in the log. CONTRIBUTING no longer says the
exe has no API key.
@sathran sathran changed the title Merge b28 into main, tighten network and import handling, correct the privacy text Tighten network and import handling, correct the privacy text Nov 4, 2026
@Topher121
Topher121 merged commit 784e082 into Topher121:main Nov 6, 2026
l3gitpanda referenced this pull request in l3gitpanda/addonforge Nov 12, 2026
The app, README and build files now point at l3gitpanda/addonforge
instead of the original project, and drop its contact details.

- Catalogue, stats, User-Agent, REPO_URL and RELEASES_URL use the fork.
- Remove SUPPORT_EMAIL and the Report on GitHub / Email buttons (issues
  are off on the fork); Copy diagnostics stays and sends nothing.
- Remove the Discord and Ko-fi links and "by Pocket Forge Studios".
- App identifier com.l3gitpanda.addonforge; author and publisher
  l3gitpanda. The stats workflow commits as github-actions[bot].
- README rewritten as a private build. LICENSE keeps the original MIT
  notice, as the licence requires, and adds one for the changes.
- Roadmap fork-identity table updated (#2, #3, #6 done; #4, #5 partly).

cargo test: 110 passed, 2 ignored. security-check, test-ui and
validate-catalog OK.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants