more little Services updates - #81
Merged
Merged
Conversation
* forward Services class to SlowControlCollection so it can log problems * add a separate buffer of monitoring (device+subject) and reject duplicates in monitoring merge period based on this, rather than the buffer. Needed as the buffer may be flushed early if we exceed the MTU size, which would otherwise bypass rate limiting. * set "Config" slow control state in LoadConfigSlowControlFunc * add conversion of line breaks in logging messages to '\n', as these otherwise break DB insertion! * report state of testing flag in LocalConfig slow control response * set SlowControlCollection warning bit if a slow control callback fails... tenatively * set SlowControlCollection error bit if an alert fails to receive, decompress, or callback function fails * make Services a friend class of SlowControlCollection, and make SetTesting, TestingEnable, TestingDisable functions private
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.