Skip to content

swap time_t to uint64_t to support 32-bit architectures #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brichards64 merged 4 commits into from
Aug 28, 2026
Merged

swap time_t to uint64_t to support 32-bit architectures #78

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce45fbd
Fix 32-bit time_t overflow in SendLog/SendMonitoringData default time…
luigi-lavitola Aug 26, 2026
c34920c
Add temporary debug print in TimeStringFromUnixMs to diagnose the 197…
luigi-lavitola Aug 26, 2026
3e0d6e3
Remove temporary debug print from TimeStringFromUnixMs - diagnosis do…
luigi-lavitola Aug 26, 2026
39ec572
Merge branch 'tsfix'
Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/ServiceDiscovery/Services.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,7 @@ bool Services::SendLog(const std::string& message, LogLevel severity, const std:
const std::string& name = (device=="") ? m_name : device;

// grab timestamp at time of call if 0
time_t ts = (timestamp!=0) ? timestamp : time(nullptr)*1000;
uint64_t ts = (timestamp!=0) ? timestamp : std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::system_clock::now().time_since_epoch()).count();

std::unique_lock<std::mutex> locker(logging_buf_mtx);

Expand Down Expand Up @@ -1038,7 +1038,7 @@ bool Services::SendMonitoringData(const std::string& json_data, const std::strin
const std::string& name = (device=="") ? m_name : device;

// grab timestamp at time of call if 0
time_t ts = (timestamp!=0) ? timestamp : time(nullptr)*1000;
uint64_t ts = (timestamp!=0) ? timestamp : std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::system_clock::now().time_since_epoch()).count();

std::unique_lock<std::mutex> locker(monitoring_buf_mtx);

Expand Down Expand Up @@ -1173,9 +1173,9 @@ std::string Services::GetDeviceName(){
// ««-------------- ≪ °◇◆◇° ≫ --------------»»

std::string Services::TimeStringFromUnixMs(uint64_t& timestamp){

if(timestamp==1) return "now()"; // remotely interpret 'now'

time_t timestamp_sec; // time_t is equivalent to uint64_t
uint16_t timestamp_ms;
if(timestamp==0){
Expand Down
Loading