Remove unused imports from several classes#59
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (21)
💤 Files with no reviewable changes (21)
📝 WalkthroughWalkthroughThis PR performs systematic import cleanup across the EntityLib codebase. Unused imports such as annotation types, stream utilities, DOM classes, and unused wrapper/utility imports are removed from API core modules, common utilities, platform implementations, and the NPC module. No functional logic, public API signatures, or control flow are modified. ChangesImport cleanup across EntityLib modules
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR performs a cleanup pass across the codebase to remove unused imports in multiple modules (spaceNPC, api, common, and platform implementations), reducing warnings and keeping files tidy.
Changes:
- Removed unused Java and library imports from NPC-related classes in
spaceNPC. - Removed unused imports from API wrapper/meta/container classes.
- Removed unused imports from platform implementations (
velocity,standalone,spigot) andcommon.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| spaceNPC/src/main/java/me/tofaa/entitylib/npc/NPCRegistry.java | Removed unused import. |
| spaceNPC/src/main/java/me/tofaa/entitylib/npc/NPCPlayerListener.java | Removed unused imports. |
| spaceNPC/src/main/java/me/tofaa/entitylib/npc/NPCListenerManager.java | Removed unused imports. |
| spaceNPC/src/main/java/me/tofaa/entitylib/npc/NPC.java | Removed unused imports. |
| spaceNPC/src/main/java/me/tofaa/entitylib/npc/command/NPCCommand.java | Removed unused import. |
| platforms/velocity/src/main/java/me/tofaa/entitylib/velocity/VelocityEntityLibPlatform.java | Removed unused imports. |
| platforms/standalone/src/main/java/me/tofaa/entitylib/standalone/StandaloneEntityLibApi.java | Removed unused import. |
| platforms/spigot/src/main/java/me/tofaa/entitylib/spigot/ExtraConversionUtil.java | Removed unused imports. |
| common/src/main/java/me/tofaa/entitylib/common/AbstractPlatform.java | Removed unused imports. |
| api/src/main/java/me/tofaa/entitylib/wrapper/WrapperLivingEntity.java | Removed unused imports. |
| api/src/main/java/me/tofaa/entitylib/wrapper/WrapperEntityEquipment.java | Removed unused import. |
| api/src/main/java/me/tofaa/entitylib/wrapper/WrapperEntityAttributes.java | Removed unused import. |
| api/src/main/java/me/tofaa/entitylib/wrapper/spawning/SpawnPacketProviders.java | Removed unused imports. |
| api/src/main/java/me/tofaa/entitylib/wrapper/spawning/SpawnPacketProvider.java | Removed unused import. |
| api/src/main/java/me/tofaa/entitylib/wrapper/hologram/ModernHologram.java | Removed unused imports. |
| api/src/main/java/me/tofaa/entitylib/wrapper/hologram/LegacyHologram.java | Removed unused import. |
| api/src/main/java/me/tofaa/entitylib/Platform.java | Removed unused imports. |
| api/src/main/java/me/tofaa/entitylib/meta/other/FishingHookMeta.java | Removed unused imports/blank line. |
| api/src/main/java/me/tofaa/entitylib/meta/mobs/golem/ShulkerMeta.java | Removed unused imports. |
| api/src/main/java/me/tofaa/entitylib/meta/Metadata.java | Removed unused imports. |
| api/src/main/java/me/tofaa/entitylib/container/EntityContainer.java | Removed unused import. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
LGTM <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused imports from several classes, initially I was going to do a lot more cleaning up but some of it was just preference, so I decided not to include those other commits.
Summary by CodeRabbit