Record MossFormer2 Colab feasibility evidence - #66
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR records the completed MossFormer2_SR_48K feasibility spike (as Colab-only evidence) without implementing a new backend, and updates roadmap/candidate documentation to reflect the results and constraints (minimal checkpoints, safe conversion, offline CPU inference, and alignment/parity considerations).
Changes:
- Adds a Colab-only spike script to reproduce checkpoint download/inspection, safetensors round-trip validation, and offline CPU inference evidence.
- Updates roadmap and backend-candidate documentation to mark the spike as complete and capture key findings (minimal files, alignment delta, tolerance-based parity).
- Documents how to run/download the spike evidence via the existing Colab CLI workflow and notes it in the changelog.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
ROADMAP.md |
Marks the candidate spike milestone as completed and summarizes the spike outcomes/constraints. |
examples/colab_mossformer2_spike.py |
New Colab-only script that reproduces and archives the MossFormer2 feasibility evidence. |
docs/BACKEND_CANDIDATES.md |
Updates the MossFormer2 candidate entry with completed feasibility evidence and implementation constraints. |
docs/ACCELERATORS.md |
Adds Colab CLI instructions for running/downloading the spike evidence archive. |
CHANGELOG.md |
Notes the addition of the MossFormer2 feasibility workflow under Unreleased. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| The evaluation policy lives in [docs/EVALUATION.md](docs/EVALUATION.md). | ||
|
|
||
| ## Priority 3: One Candidate Spike, Not Three Implementations | ||
| ## Completed: One Candidate Spike, Not Three Implementations |
Comment on lines
+61
to
+65
| def download_checkpoints() -> list[dict[str, object]]: | ||
| from huggingface_hub import hf_hub_download | ||
|
|
||
| CHECKPOINT_DIR.mkdir(parents=True, exist_ok=True) | ||
| records = [] |
Comment on lines
+91
to
+92
| conversion_dir = EVIDENCE_DIR / "converted" | ||
| conversion_dir.mkdir() |
Comment on lines
+265
to
+276
| run( | ||
| "install-dependencies", | ||
| [ | ||
| "uv", | ||
| "pip", | ||
| "install", | ||
| "--system", | ||
| "-e", | ||
| str(SOURCE_DIR / "clearvoice"), | ||
| "safetensors", | ||
| ], | ||
| ) |
Comment on lines
+223
to
+226
| def archive() -> None: | ||
| with tarfile.open(ARCHIVE_PATH, "w:gz") as bundle: | ||
| bundle.add(EVIDENCE_DIR, arcname="evidence") | ||
| print(f"[mossformer2-spike] evidence archive: {ARCHIVE_PATH}", flush=True) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MossFormer2_SR_48Kfeasibility workflowRemote evidence
modelscope/ClearerVoice-Studio@6b3774dc79c46ae8bed2a4fa5f706f0ac8c75c61alibabasglab/MossFormer2_SR_48K@39eb1f25ea84f5e0315ade9ac0070fff216fc690m+g; 1.74 GB training file not downloadedweights_only=Trueand exactly round-trip through safetensors-224sample output alignment deltaAll checkpoint, model, audio, and HPE work ran via Colab CLI.
Local verification
git diff --checkpixi run lintpixi run format-checkpixi run typecheckpixi run test(163 passed, 6 skipped)