Add eval regression baseline workflow - #62
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a versioned evaluation regression threshold policy and supporting evidence workflow to enable deterministic baseline/candidate comparisons (same backend) and to document/validate the resulting artifacts. It also corrects metric direction handling so elapsed-time fields are consistently treated as “lower is better” during comparisons.
Changes:
- Introduces a release regression threshold policy artifact (
eval-threshold-policy.json) plus tests validating it viaload_threshold_policy. - Adds a Colab-focused regression evidence collection script that clones immutable refs, runs eval matrices, compares results, and archives evidence.
- Updates evaluation metric direction handling to treat
load_time_secondsandtotal_elapsed_secondsaslower_is_better, with a targeted test.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_release_artifacts.py | Adds a test ensuring the new threshold policy artifact loads/validates correctly. |
| tests/test_eval.py | Adds coverage for elapsed-time metrics being treated as lower_is_better in comparisons. |
| src/audio_super_resolution/evaluation.py | Extends LOWER_IS_BETTER_METRICS to include load_time_seconds and total_elapsed_seconds. |
| examples/colab_eval_regression.py | New Colab regression evidence workflow script for baseline/candidate eval collection and archiving. |
| examples/artifacts/README.md | Documents the new threshold policy artifact. |
| examples/artifacts/eval-threshold-policy.json | Adds the versioned same-backend regression threshold policy. |
| docs/EVALUATION.md | Documents the maintained threshold policy and cautions against cross-hardware performance comparisons. |
| docs/ACCELERATORS.md | Adds usage instructions for running the new Colab regression evidence flow. |
| CHANGELOG.md | Notes the new policy/workflow and the metric direction fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+179
to
+184
| if Path.cwd() != Path("/content"): | ||
| raise RuntimeError("This regression workflow must run inside a Colab runtime rooted at /content") | ||
|
|
||
| if WORK_ROOT.exists(): | ||
| shutil.rmtree(WORK_ROOT) | ||
| EVIDENCE_DIR.mkdir(parents=True) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Colab T4 evidence
Baseline v0.6.0 at 5e4241c was compared with candidate 7662458 on a Tesla T4. The workflow generated an eight-item deterministic speech evalset and ran wideband_16k and lowpass_4k matrices.
A remote follow-up verified load_time_seconds and total_elapsed_seconds are now reported as lower_is_better and regenerated the comparison archive. No model or matrix inference ran locally.
Local lightweight checks