Skip to content

fix: polish map service API #2683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rsynek wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −3
Open

fix: polish map service API #2683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e1ef80
fix: polish map service API
rsynek Sep 23, 2026
388521d
add javadoc
rsynek Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...ain/java/ai/timefold/solver/service/maps/service/client/api/TravelTimeMatrixEnricher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import java.time.temporal.ChronoUnit;
import java.util.Collections;
import java.util.List;
import java.util.Objects;

import jakarta.enterprise.context.ApplicationScoped;
import jakarta.inject.Inject;
Expand Down Expand Up @@ -62,7 +63,8 @@ public LocationsAwareSolverModel<?> enrich(LocationsAwareSolverModel<?> solverMo
}

private LocationsAwareSolverModel<?> enrichSingleMatrix(LocationsAwareSolverModel<?> solverModel) {
List<Location> locations = solverModel.getLocations(); // Get all the locations from the model only once.
// Get all the locations from the model only once.
List<Location> locations = Objects.requireNonNull(solverModel.getLocations(), "List of locations cannot be null.");
TravelTimeAndDistanceWithMetadata travelTimeAndDistance;
try {
travelTimeAndDistance =
Expand All @@ -85,7 +87,7 @@ private LocationsAwareSolverModel<?> enrichSingleMatrix(LocationsAwareSolverMode
}

private LocationsAwareSolverModel<?> enrichAllTimeframes(LocationsAwareSolverModel<?> solverModel) {
List<Location> locations = solverModel.getLocations();
List<Location> locations = Objects.requireNonNull(solverModel.getLocations(), "List of locations cannot be null.");
TravelTimesByTimeframeWithMetadata result;
try {
result = mapService.getTravelTimeAndDistanceByTimeframe(locations, optionsSupplier.getOptions());
Comment thread
rsynek marked this conversation as resolved.
Expand Down
9 changes: 8 additions & 1 deletion ...va/ai/timefold/solver/service/maps/service/integration/api/LocationsAwareSolverModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,14 @@ public interface LocationsAwareSolverModel<Score_ extends Score<Score_>> extends

List<Location> getLocations();

Optional<String> getLocationSetName();
/**
* Returns the optional name of the location set used for map-service requests.
*
* @return the location-set name, or {@link Optional#empty()} when no name is configured
*/
default Optional<String> getLocationSetName() {
return Optional.empty();
Comment thread
rsynek marked this conversation as resolved.
}

void setLocationsNotInMap(List<Location> locationsNotInMap);

Expand Down
Loading