Conversation
rsynek
reviewed
Sep 17, 2026
Comment on lines
+368
to
+384
| Build the matrix yourself in the test fixture, using the same Haversine provider the platform uses | ||
| for its local computation: | ||
|
|
||
| [source,java] | ||
| ---- | ||
| import ai.timefold.solver.service.maps.haversine.impl.HaversineTravelTimeAndDistanceMatrixProvider; | ||
| import ai.timefold.solver.service.maps.service.test.api.TestDistanceCalculator; | ||
|
|
||
| private static final HaversineTravelTimeAndDistanceMatrixProvider PROVIDER = | ||
| new HaversineTravelTimeAndDistanceMatrixProvider(new ObjectMapper()); | ||
|
|
||
| public static VehicleRoutePlan initDistanceMap(VehicleRoutePlan plan) { | ||
| TestDistanceCalculator.initDistanceMaps(plan.getLocations(), // <1> | ||
| PROVIDER::calculateDistance, | ||
| PROVIDER::calculateTravelTime); | ||
| return plan; | ||
| } |
Contributor
There was a problem hiding this comment.
This creates the impression that you need both the Haversine and the TestDistanceCalculator together.
You don't and specifically for tests, I would advise against that: in tests, pretty, easily verifiable numbers are preferred. The TestDistanceCalculator is a stub that returns what you want:
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rsynek, need your help pulling this over the finish line.