Skip to content

fix(ci): sync npm 11 lockfile dependencies#61

Merged
TimBeyer merged 1 commit into
masterfrom
fix/npm11-lockfile
Jul 13, 2026
Merged

fix(ci): sync npm 11 lockfile dependencies#61
TimBeyer merged 1 commit into
masterfrom
fix/npm11-lockfile

Conversation

@TimBeyer

Copy link
Copy Markdown
Owner

What changed

  • Record optional encoding@0.1.13 and its nested iconv-lite@0.6.3 dependency in package-lock.json.
  • Preserve every existing dependency version and peer marker.

Why

Node 25 ships npm 11, which validates optional transitive dependencies during npm ci. The existing merge-base lockfile omitted these two records, so CI stopped during dependency installation before build, lint, tests, or performance comparisons could run.

The performance workflow benchmarks the merge-base first, so this fix must land on master before optimization PR benchmarks can obtain a valid baseline.

Validation

  • Clean npm ci --ignore-scripts with Node 25.7.0 / npm 11.10.1
  • Lockfile diff is limited to the two missing package records (25 added lines)

Record encoding@0.1.13 and its iconv-lite@0.6.3 dependency in the npm lockfile. npm 11 validates optional transitive dependencies during npm ci and rejected the previous lockfile before any build, lint, test, or benchmark job could run.\n\nThe patch intentionally preserves every existing dependency version and peer marker; a clean Node 25/npm 11 install now succeeds.
@TimBeyer
TimBeyer merged commit 58aa52d into master Jul 13, 2026
8 of 12 checks passed
@TimBeyer
TimBeyer deleted the fix/npm11-lockfile branch July 13, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant