Fix two causes of flaky nightly builds - #2311
Merged
Merged
Conversation
The test failed whenever its body took over 2s, which a shared CI runner does now and then, while the round trip itself passed. It was left in to debug #1194; the test now checks only what it reads back.
…be fetched file(DOWNLOAD) without STATUS leaves an empty file on failure and no error, so a dropped download surfaced later as "string sub-command STRIP requires two arguments". It is now retried three times and then reported with the URL and reason.
teo-tsirpanis
approved these changes
Sep 25, 2026
teo-tsirpanis
left a comment
teo-tsirpanis
left a comment
Member
There was a problem hiding this comment.
Reluctant approve; not a big fan of this approach, but I don't see anything very wrong.
Related to this, it would make more sense to me for nightly builds to build TileDB from source; either the dev branch or the latest release from vcpkg, which would feature an updated set of dependencies.
Comment on lines
+52
to
+69
| foreach(ATTEMPT RANGE 1 ${ATTEMPTS}) | ||
| file(DOWNLOAD | ||
| ${UPSTREAM_URL}/${VERSION}/releases.csv | ||
| ${RELLIST_URL} | ||
| ${CMAKE_CURRENT_BINARY_DIR}/releases.csv | ||
| SHOW_PROGRESS | ||
| ${HASH_ARGS} | ||
| STATUS DOWNLOAD_STATUS | ||
| ) | ||
| list(GET DOWNLOAD_STATUS 0 DOWNLOAD_CODE) | ||
| list(GET DOWNLOAD_STATUS 1 DOWNLOAD_MESSAGE) | ||
| if(DOWNLOAD_CODE EQUAL 0) | ||
| break() | ||
| endif() | ||
| message(WARNING "Downloading ${RELLIST_URL} failed (attempt ${ATTEMPT} of ${ATTEMPTS}): ${DOWNLOAD_MESSAGE}") | ||
| if(ATTEMPT LESS ATTEMPTS) | ||
| execute_process(COMMAND ${CMAKE_COMMAND} -E sleep 5) | ||
| endif() | ||
| endforeach() |
Member
There was a problem hiding this comment.
I'm not a fan of adding retry logic in our own build system code. I wish CMake supported that itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STRIP requires two argumentserror.