Skip to content

1 cause of discrepancy #4

Description

@motiwari

I've discovered at least one cause of discrepancy between our master and Lorraine's:
https://github.com/ThrunGroup/implicit-hyper-opt/blob/master/data_loaders.py#L75-L81

Somehow, when we changed train_data to data and train_labels to targets, this results in different behavior.

Additionally, it's not clear to me why num_train is used for the val set as well

I'm also not sure why changing those field names leads to different behavior

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions