Test-build pipeline Phase B, PR 1: mechanical cleanups and small consolidations - #1218
Merged
mkarlesky merged 9 commits intoAug 20, 2026
Merged
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The _now suffix was a disambiguation artifact from the earliest refactoring that extracted Rake from the core of the test-build pipeline, no longer meaningful today -- same pattern already resolved for generate_executable_now. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…elper Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…edicate Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Matches PartialWork/MockWork, the same kind of flattened per-item record T1/T2 already use for their own parallel-processing lists. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
TestBuildSetup and TestBuildPlanner each defined the identical Partial-mock naming check independently; both already include TestPipelineHelpers, so it lives there now under its one name. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Also brings its doc comment's params back in line with the method's actual current signature -- it previously documented header_filepath/ source_filepath, neither of which this method takes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Keeps the if/elsif dispatch on filepath -- it's priority-ordered and config-gated, not a plain Symbol-keyed lookup -- but gives each branch's own path-building its own name. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Aug 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First of four PRs implementing Phase B of the test-build pipeline (
lib/ceedling/test_invoker/) architecture review, following PR #1217 (Phase A). This PR bundles the lowest-risk, non-overlapping items -- all behavior-preserving, none touching DI wiring or adding a new class.stage_flatten_objects_list's nestedmap { ... }.flattentoflat_map.run_fixture_nowtorun_fixture(same historical_nowRake-extraction-artifact pattern already resolved forgenerate_executable_nowin Phase A).TestPipelineHelpersmethods: the vendor-path array literal (11 call sites), the{ flags:, defines:, search_paths: }meta-hash (6 call sites), and (private toTestBuildExecutor) the directives-only fallback condition (4 call sites).objects_list's raw{ test:, obj: }Hash entries with a namedObjectWorkstruct, matchingPartialWork/MockWork's existing pattern for the sibling T1/T2 transforms.TestBuildSetup#mock_partial?/TestBuildPlanner#is_mock_partial?predicates into one sharedTestPipelineHelpersmethod.Partializer#extract_module_contents's boolean-trap third positional arg to a keyword arg (fallback:), and bring its doc comment back in line with the method's actual current signature.tailor_search_paths's four branches into named private methods for readability, keeping the if/elsif dispatch itself (a true Hash-dispatch table would need a Hash of Procs here, not a Hash of static values -- not a good fit for this method's config-gated, priority-ordered matching).Test plan
bundle exec rspec spec/units-- 2588 examples, 0 failuresNo targeted Docker system-spec run for this PR -- every change here is either behavior-preserving with strong existing unit coverage, or (the
extract_module_contentskeyword-arg change) touchesPartializerwith its own strong existing spec. Relying on CI for system coverage.🤖 Generated with Claude Code