feat: Add wall-clock, heap, and output size resource limits#4
Merged
Conversation
Shared ResourceLimits validation, budgeted output metering with output-too-large, and hard worker.terminate on deadline and abort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fills out the resource limit layer for every airlock tier. Timeout and heap already lived on the worker path; this PR makes them a shared ResourceLimits contract, hard-kills the isolate on both the deadline and a caller abort, and adds maxOutputBytes so a huge return never reaches the post-condition as a trusted value.
Output size is a budgeted walk over the value (UTF-8 string payload, typed arrays by byteLength, cycle-safe with WeakSet) so metering itself cannot hang the host. Oversize comes back as output-too-large without the payload attached. Tests cover empty/boundary/oversize, cyclic structures, invalid limit values, and terminate-on-abort timing for now.