Conversation
A comment in `crates/common/src/errors.rs` cited `thinkwatch-core DESIGN §9.3`, a document that exists in none of the three repositories. The same cleanup just landed in Core and Lite; this is the only site here. The sentence already carried the whole argument — the shared layer must not know this crate's error taxonomy, which is why `tw-crypto` has its own `SecretError` — so only the pointer goes. Every other section reference in this repo is left alone, because they are real: RFC 6749, 6585, 7231, 7591, 7636, 8414 and 9728, the MCP authorization spec, and `LICENSING.md §Tier Determination`, which is an actual heading in an actual file here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One comment in
crates/common/src/errors.rscitedthinkwatch-core DESIGN §9.3— a document that exists in none of the three repositories. The same cleanup just landed in ThinkWatchProject/ThinkWatch-Core#8 and ThinkWatchProject/ThinkWatch-Lite#12; this is the single site here.The citation goes, the reasoning stays — the sentence already said the whole thing: the shared layer must not know this crate's error taxonomy, which is why
tw-cryptocarries its ownSecretError.What was deliberately left alone
Every other
§in this repo is a real citation and stays: RFC 6749, 6585, 7231, 7591, 7636, 8414, 9728, the MCP authorization spec, andLICENSING.md §Tier Determination(that section does exist inLICENSING.md). Those point at documents a reader can actually open.Verification
cargo fmt --all -- --check,cargo clippy --workspace --all-targets -- -D warnings, and 635 tests pass locally.🤖 Generated with Claude Code