Use core v0.60.0: auxiliary requests are answered locally or forwarded - #274
Merged
Merged
Conversation
Core v0.60.0 has two modes for client helper requests instead of three. "Pass through" and "Use routing" both went through the routing rules and differed only in whether a rule's auxiliary-request condition could match; they are now one mode, "Forward", and that condition takes effect as soon as a rule uses it. - Auxiliary tab: two-way segmented control, copy says forwarded requests follow the routing rules - Rule dialog: the "set these categories to be routed on save" checkbox is gone; a warning names the classes the condition picks that are answered locally (they never reach routing), unless "any auxiliary request" is chosen - Route dialog: no longer sends route_probes - Dry run: the pass-through outcome is gone - Pin core v0.60.0 (protocol 36); regenerated tw-api.ts, fixtures and the zh message table Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Core v0.60.0 (ThinkWatch-Core#281) gives client helper requests two modes instead of three. "Pass through" and "Use routing" both went through the routing rules and differed only in whether a rule's auxiliary-request condition could match, while the names and the dry run suggested that "Pass through" skipped routing. They are now one mode, "Forward": a forwarded helper request carries its class, so a rule's auxiliary-request condition takes effect as soon as it is written.
What
route_probes(removed fromRouteSave).tw-api.ts; update fixtures, shot data andcore.zh.json(control.unknown_probe_classremoved).Upgrade note
A
config.yamlthat setsclient_probes.<class>topassthroughorroutedoes not load in core 0.60.0 (safe mode). Configs that never changed the Auxiliary tab are unaffected. Agreed to cover this in the release notes only, without a compatibility path.Tests
pnpm typecheck,pnpm test(744 passed)cargo fmt --check,cargo clippy --all-targets -D warnings,cargo testwith a twcore built at v0.60.0 (all passed, including control_plane handshake tests)🤖 Generated with Claude Code