Keep a request database written by a newer version - #280
Merged
Merged
Conversation
tw_store::open rebuilt the request database, bodies included, whenever its schema version differed from this build's, in either direction. An older twcore opening a newer database therefore wiped the history the newer version would read again: installing an older release over a newer one, or a second desktop copy on the same machine that has not updated yet. Only an older database is rebuilt now. A newer one is left as it is and open returns OtherVersion, so this run records nothing (the existing "recording: false" path) and forwarding is unaffected; the newer version reads it again unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
tw_store::openrebuilt the request database (bodies included) whenever its schema version differed from this build's, in either direction. An older twcore opening a database written by a newer one therefore wiped history that the newer version would have read again. That happens when an older release is installed over a newer one. It will also happen when a second desktop copy on the same machine has not updated yet. The Lite Windows portable build makes the second case more likely.What
openreturnsOtherVersion.build_storealready turns that into "nothing is recorded this run, forwarding is unaffected", and/storagereportsrecording: false. The newer version later opens it unchanged.user_versionand its bodies. The existing rebuild test is renamed to say "older".No protocol, config or message-code change.
🤖 Generated with Claude Code