feat: implement offline channel calibration for outlier strategy#94
Open
andrea-gentilini wants to merge 1 commit into
Open
feat: implement offline channel calibration for outlier strategy#94andrea-gentilini wants to merge 1 commit into
andrea-gentilini wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements offline channel calibration for the OutlierTurboQuant strategy as described in Section 4.3 of the paper (references [63, 51]).
I noticed the comment in
outlier.pystating:This PR implements exactly that practical approach without breaking the data-oblivious runtime constraint.
Changes:
calibration.pyutility that sorts and extracts the top indices based on mean absolute magnitude.outlier_idxan optional parameter inOutlierTurboQuant. If left asNone, it safely falls back to the originalnp.arangebehavior.By running the calibration once offline, the indices are passed to the quantizer, which remains 100% data-oblivious during the actual compression (O(1) index mapping), but correctly targets the real "Attention Sinks" instead of blindly assuming they live in the first$N$ channels.