perplexity: respect explicit -np instead of silently overriding it - #353
Merged
TheTom merged 1 commit intoSep 6, 2026
Merged
Conversation
tools/perplexity/perplexity.cpp's plain-PPL/KLD path computed n_parallel = max(1, n_batch / n_ctx) unconditionally, discarding whatever -np/--parallel was passed - including an explicit -np 1 needed to satisfy --kv-stream's single-sequence gate. Added n_parallel_explicit tracking (same pattern as the existing moe_cache.mode_explicit field) so an explicit -np now sticks; the auto-batching heuristic still applies unchanged when -np isn't passed. Assisted-by: Claude
TheTom
merged commit Sep 6, 2026
23fcf04
into
TheTom:feature/turboquant-kv-cache
9 of 24 checks passed
Owner
|
Merged. Exactly the split I asked for: the heuristic only runs when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out of #326 per review comment: #326 (comment)
The plain-PPL/KLD path in
tools/perplexity/perplexity.cppcomputedn_parallel = max(1, n_batch / n_ctx)unconditionally, discarding whatever-np/--parallelwas passed on the command line — including an explicit-np 1needed to satisfy--kv-stream's single-sequence gate.n_parallel_explicittracking (same pattern as the existingmoe_cache.mode_explicitfield) so an explicit-npnow sticks.-npisn't passed.Test plan
llama-perplexitytarget)-npis omitted (heuristic path untouched)🤖 Generated with Claude Code