ci: sync the HIP VGPR-spill ignore list with upstream - #341
Merged
TheTom merged 1 commit intoSep 3, 2026
Merged
Conversation
…urbo3 vector FA kernel
The ubuntu-22-hip-quality-check job has been red on every recent PR with the
same four kernels, none of which the PRs touch:
rwkv_wkv_f32<128> 387 VGPRs (64 + 323 spilled)
mul_mat_q<Q2_K, 64, fallback> 317 VGPRs (128 + 189 spilled)
flash_attn_ext_vec<128, 2, turbo3, q8_0, {false,true}> 259 VGPRs (255 + 4 spilled)
The first two are on upstream's current ignore list; this branch still carried
an older, longer list that predates those entries and no longer matches any
kernel that is over the limit. Replace it with upstream's list and add the two
TurboQuant vector flash-attention instances, which sit three registers over
the threshold. Trimming that spill is a separate change; this only makes the
check report new regressions instead of the baseline.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NxP6x5bmUDYFvmouceN2mR
TheTom
merged commit Sep 3, 2026
4ff4bd3
into
TheTom:feature/turboquant-kv-cache
2 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
ubuntu-22-hip-quality-checkhas been red on every recent PR against this branch (#334, #335, #337) with the same four kernels over the 256-VGPR line, none of which those PRs touch:rwkv_wkv_f32<128>mul_mat_q<Q2_K, 64, fallback>flash_attn_ext_vec<128, 2, turbo3, q8_0, false>flash_attn_ext_vec<128, 2, turbo3, q8_0, true>The first two are on upstream's current ignore list in
scripts/hip/gcn-cdna-vgpr-check.py. This branch carries an older 85-entry copy of that list which predates those entries and no longer matches any kernel that is over the limit. This PR replaces it with upstream's current list and adds the two TurboQuant vector flash-attention instances, which sit three registers over the threshold.Trimming that 4-VGPR spill is a separate change; this only makes the check report new regressions instead of the baseline.
Additional information
Script-only change, no code. The ignore list is matched by mangled name, so the two added entries are the exact symbols from the failing job's
metrics.log.Requirements
🤖 Generated with Claude Code
https://claude.ai/code/session_01NxP6x5bmUDYFvmouceN2mR