Repository navigation
Data-quality: inventory TabletType must match the tablet's Model.Type - #63
Merged
Merged
Conversation
An inventory tablet unit's TabletType restates its tablet's Model.Type, but nothing compared them: HUT.0019, a Kamvas Pro 24 GEN3 pen display, sat as a PENTABLET until the purchase-record reconciliation (#62). The cross-entity inventory check now reports a TabletType that isn't the tablet's Model.Type, beside the existing ModelId check. Run against the inventory as it was before #62, it flags exactly HUT.0019; the current data is clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: an inventory tablet unit's
TabletTyperestates its tablet'sModel.Type, but nothing compared the two. HUT.0019, a Kamvas Pro 24 GEN3 pen display, was recorded as aPENTABLETuntil the purchase-record reconciliation in #62.After: data-quality reports a unit whose
TabletTypeisn't its tablet'sModel.Type, for exampleHUT.0019 TabletType: is not the tablet's Model.Type (got "PENTABLET", huion.tablet.gt2402 has "PENDISPLAY"). Run against the inventory as it was before #62, the check flags exactly HUT.0019. The current data is clean.How: the check sits beside the existing ModelId check in
runCrossEntityChecks, reusing the same per-tablet lookup.data-quality-inventory.test.tsadds a mismatch case, and a case showing that a missingTabletTypeis reported once by the schema check with no extra mismatch issue. Vitest,typecheck,typecheck:scriptsand data-quality pass locally.🤖 Generated with Claude Code