Repository navigation
Spec audit, first pass: included pens in pen-compat, swapped body sizes - #58
Merged
Merged
Conversation
- Every tablet's included pen is now in that pen's pen-compat row (16 were missing), and data-quality checks it from now on. - Cintiq 24 / 24 touch (2025) and Cintiq 16 (2025) had body width and height swapped, so the body read narrower than the active area. - Intuos Small Bluetooth: digitizer type PASSIVE_EMR, as the wired model. Part of #54. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JKHYepZSQw6ek2WLhWP4jf
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: 16 tablets shipped with a pen that the pen's pen-compat row didn't list, so pen pages left those tablets out. Cintiq 24, Cintiq 24 touch and Cintiq 16 (all 2025 models) had body width and height swapped, so the body read narrower than the active area. The Intuos Small Bluetooth had no digitizer type.
After: each included pen's pen-compat row lists its tablet, and
data-qualitynow reports any tablet whose included pen is missing from pen-compat. The three Cintiq bodies are landscape, and the Intuos Small Bluetooth is PASSIVE_EMR like the wired model.These are the first fixes from the mechanical pass in #54.
How:
commitDatasetUpdateadds the tablet to each pen-compat row. When a pen has no row yet, it inserts one in PenId order. Existing rows keep their order.scripts/edit.tshandles the tablet fields. The new check lives inrunCrossEntityChecksand is tested indata-quality-included-pen.test.ts. Vitest,data-quality,format-dataandgenerateare all clean.typecheckreports the same 309 errors as master.🤖 Generated with Claude Code
https://claude.ai/code/session_01JKHYepZSQw6ek2WLhWP4jf
Generated by Claude Code