Skip to content

fix(layout): prioritise chart height across all laptop resolutions #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SyntaxSphinx merged 1 commit into from
Aug 7, 2026
Merged

fix(layout): prioritise chart height across all laptop resolutions #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/NBBOBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function NBBOBar({ bestBid, bestAsk, spread, symbol, isConnected }: Props
style={{
background: 'var(--bg-secondary)',
borderBottom: '1px solid var(--border-color)',
padding: '4px 16px',
padding: 'var(--nbbo-pad-y, 4px) var(--pad-x, 16px)',
display: 'flex',
alignItems: 'center',
gap: '20px',
Expand Down
8 changes: 4 additions & 4 deletions frontend/src/components/SystemPipeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ export const SystemPipeline: React.FC<SystemPipelineProps> = ({ lifecycle, isCon
<div
className="terminal-panel pipeline-banner"
style={{
padding: '8px var(--pad-x, 14px)',
padding: 'var(--pipeline-pad-y, 8px) var(--pad-x, 14px)',
background: 'linear-gradient(180deg, #0A0E1A 0%, #05080E 100%)',
borderBottom: '2px solid var(--border-color)',
borderRadius: 0,
Expand All @@ -204,7 +204,7 @@ export const SystemPipeline: React.FC<SystemPipelineProps> = ({ lifecycle, isCon
}}
>
{/* Header */}
<div style={{ display: 'flex', alignItems: 'center', justifyContent: 'space-between', marginBottom: '6px' }}>
<div style={{ display: 'flex', alignItems: 'center', justifyContent: 'space-between', marginBottom: 'var(--pipeline-inner-gap, 6px)' }}>
<div style={{ display: 'flex', alignItems: 'center', gap: '8px' }}>
<Radio size={12} color="var(--accent-cyan)" />
<span style={{ fontSize: '10px', fontWeight: 800, textTransform: 'uppercase', letterSpacing: '0.8px', color: 'var(--text-main)' }}>
Expand Down Expand Up @@ -283,7 +283,7 @@ export const SystemPipeline: React.FC<SystemPipelineProps> = ({ lifecycle, isCon
ref={el => { nodeRefs.current[idx] = el; }}
className={extraClass}
style={{
width: '24px', height: '24px', borderRadius: '50%',
width: 'var(--pipeline-node-size, 24px)', height: 'var(--pipeline-node-size, 24px)', borderRadius: '50%',
background: bgCol,
border: `1.5px solid ${borderCol}`,
display: 'flex', alignItems: 'center', justifyContent: 'center',
Expand Down Expand Up @@ -320,7 +320,7 @@ export const SystemPipeline: React.FC<SystemPipelineProps> = ({ lifecycle, isCon
</span>

{/* Subtext */}
<span className="mono" style={{
<span className="mono pipeline-node-sub" style={{
fontSize: '7px', marginTop: '1px', display: 'block',
color: isMD && isConnected ? 'var(--buy-green)'
: subtext.startsWith('+') ? 'var(--accent-cyan)'
Expand Down
95 changes: 64 additions & 31 deletions frontend/src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,14 @@
--header-h: 52px;
--tab-h: 30px;
--dock-h: clamp(160px, 26vh, 250px);
--chart-h: clamp(120px, 20vh, 170px);
--ticket-h: clamp(200px, 30vh, 270px);
/* feed-h is shared by the feed panel AND the journey panel so that
chart height always equals ticket height within their columns */
--feed-h: 140px;
/* Pipeline chrome density controls */
--pipeline-pad-y: 8px;
--pipeline-inner-gap: 6px;
--pipeline-node-size: 24px;
--nbbo-pad-y: 4px;
--ui-scale: 1;
}

Expand Down Expand Up @@ -119,8 +125,7 @@ body {
flex: 1 1 auto;
min-height: 0;
min-width: 0;
overflow-x: hidden;
overflow-y: auto;
overflow: hidden;
display: grid;
grid-template-columns: var(--col-left) minmax(0, 1fr) var(--col-right);
grid-template-rows: minmax(280px, 1fr);
Expand Down Expand Up @@ -157,30 +162,39 @@ body {
}

.workspace-panel--chart {
flex: 0 1 var(--chart-h);
height: var(--chart-h);
max-height: var(--chart-h);
flex: 1 1 0;
min-height: 160px;
overflow: hidden;
}

.workspace-panel--feed {
flex: 1 1 auto;
min-height: 120px;
flex: 0 0 var(--feed-h);
min-height: 0;
overflow: hidden;
}

.workspace-panel--feed > .terminal-panel {
overflow-y: auto;
}

.workspace-panel--ticket {
flex: 0 1 var(--ticket-h);
height: var(--ticket-h);
max-height: var(--ticket-h);
flex: 1 1 0;
min-height: 160px;
overflow: hidden;
}

.workspace-panel--ticket .terminal-panel {
overflow: auto;
.workspace-panel--ticket > .terminal-panel {
overflow-y: auto;
}

.workspace-panel--journey {
flex: 1 1 auto;
min-height: 100px;
flex: 0 0 var(--feed-h);
min-height: 0;
overflow: hidden;
}

.workspace-panel--journey > .terminal-panel {
overflow-y: auto;
}

.bottom-dock {
Expand Down Expand Up @@ -478,7 +492,8 @@ select.input-field {
}

/* ─── Responsive density breakpoints ─────────────────────────────────────────── */
/* 1600×900 and similar */

/* 1600×900 — first density tier */
@media (max-width: 1600px) {
:root {
--col-left: 240px;
Expand All @@ -487,13 +502,16 @@ select.input-field {
--pad-x: 12px;
--pad-y: 10px;
--dock-h: clamp(150px, 24vh, 230px);
--chart-h: clamp(110px, 18vh, 155px);
--ticket-h: clamp(190px, 28vh, 250px);
--feed-h: 125px;
--pipeline-pad-y: 6px;
--pipeline-inner-gap: 5px;
--pipeline-node-size: 22px;
--nbbo-pad-y: 3px;
--ui-scale: 0.96;
}
}

/* 1440×900 */
/* 1440×900 / 1366×768 — pipeline subtext hidden to reclaim ~10px of chrome */
@media (max-width: 1440px) {
:root {
--col-left: 220px;
Expand All @@ -503,18 +521,26 @@ select.input-field {
--pad-y: 8px;
--header-h: 48px;
--dock-h: clamp(140px, 24vh, 210px);
--chart-h: clamp(100px, 17vh, 145px);
--ticket-h: clamp(180px, 28vh, 240px);
--feed-h: 112px;
--pipeline-pad-y: 5px;
--pipeline-inner-gap: 4px;
--pipeline-node-size: 20px;
--nbbo-pad-y: 3px;
--ui-scale: 0.93;
}

.analytics-layout {
grid-template-columns: minmax(140px, 180px) minmax(0, 1fr);
gap: 14px;
}

/* Hide per-node timing subtext — saves ~10px of pipeline height */
.pipeline-node-sub {
display: none;
}
}

/* 1366×768 / 1536×864 / 1280×720 */
/* 1536×864 / 1366×768 / 1280×720 */
@media (max-width: 1280px) {
:root {
--col-left: 200px;
Expand All @@ -525,8 +551,11 @@ select.input-field {
--header-h: 46px;
--tab-h: 28px;
--dock-h: clamp(130px, 26vh, 190px);
--chart-h: clamp(96px, 16vh, 130px);
--ticket-h: clamp(170px, 30vh, 220px);
--feed-h: 100px;
--pipeline-pad-y: 4px;
--pipeline-inner-gap: 3px;
--pipeline-node-size: 18px;
--nbbo-pad-y: 2px;
--ui-scale: 0.9;
}

Expand Down Expand Up @@ -554,24 +583,28 @@ select.input-field {
}
}

/* Short laptop viewports — keep chrome + dock, let workspace scroll */
/* Height breakpoint — 1366×768 and similar short laptops */
@media (max-height: 800px) {
:root {
--dock-h: clamp(120px, 22vh, 180px);
--chart-h: clamp(90px, 15vh, 130px);
--ticket-h: clamp(160px, 28vh, 220px);
--feed-h: 100px;
}

.workspace {
grid-template-rows: minmax(220px, 1fr);
grid-template-rows: minmax(200px, 1fr);
}
}

/* Height breakpoint — 1280×720 extreme compact */
@media (max-height: 720px) {
:root {
--dock-h: clamp(110px, 20vh, 160px);
--chart-h: clamp(80px, 14vh, 120px);
--ticket-h: clamp(150px, 26vh, 200px);
--feed-h: 88px;
--header-h: 44px;
--pipeline-pad-y: 3px;
--pipeline-inner-gap: 2px;
--pipeline-node-size: 16px;
--nbbo-pad-y: 2px;
}
}

Loading