Release CodeStory 0.17.7

.github/scripts/build-marketplace-fixture.test.mjs

@@ -57,7 +57,19 @@ test("the fixture catalog carries the fields the resolver requires", () => {
     const [plugin] = catalog.plugins;
     assert.deepEqual(Object.keys(plugin).sort(), PLUGIN_KEYS);
     assert.equal(plugin.name, "codestory");
+    assert.deepEqual(plugin.policy, {
+      installation: "AVAILABLE",
+      authentication: "ON_INSTALL",
+    });
+    assert.equal(plugin.category, "Developer Tools");
     assert.deepEqual(Object.keys(plugin.source).sort(), SOURCE_KEYS);
+    // Key sets alone do not pin a delivery: a wrong source kind or repository
+    // URL resolves a different (or no) plugin while passing every key check.
+    assert.equal(plugin.source.source, "git-subdir");
+    assert.equal(
+      plugin.source.url,
+      "https://github.com/TheGreenCedar/CodeStory.git",
+    );
     assert.equal(plugin.source.sha, commit);
     assert.equal(plugin.source.path, "plugins/codestory");
   } finally {
@@ -96,8 +108,29 @@ test("the fixture identifies itself and the commit it pins", () => {
     assert.equal(marker.schema_version, 1);
     assert.equal(marker.purpose, "codestory-candidate-pinned-marketplace-fixture");
     assert.equal(marker.pinned_commit, commit);
+    // The consumer requires the marker's version to be the pinned commit's own
+    // plugin version; compare it, do not only require the key to exist.
+    const pinnedManifest = JSON.parse(
+      execFileSync(
+        "git",
+        [
+          "-C",
+          repositoryRoot,
+          "show",
+          `${commit}:plugins/codestory/.codex-plugin/plugin.json`,
+        ],
+        { encoding: "utf8" },
+      ),
+    );
+    assert.equal(marker.plugin_version, pinnedManifest.version);
     // The marker must be committed, or a clean-tree check would pass over a fixture that had
-    // been re-marked after the fact.
+    // been re-marked after the fact. ls-files --error-unmatch proves the marker is in the
+    // committed tree -- a gitignored marker leaves status clean while never being delivered.
+    execFileSync(
+      "git",
+      ["-C", out, "ls-files", "--error-unmatch", ".codestory-marketplace-fixture.json"],
+      { encoding: "utf8" },
+    );
     assert.equal(
       execFileSync("git", ["-C", out, "status", "--porcelain"], { encoding: "utf8" }).trim(),
       "",

.github/scripts/cargo-build-artifacts.test.mjs

@@ -684,6 +684,22 @@ test("rejects debug-profile output even when the target name matches", () => {
   assert.throws(() => build(input), /not built with the release profile/u);
 });
 
+// Each release-profile predicate is an independent admission check: a row that
+// trips several at once cannot tell whether a dropped check would still fail.
+for (const [field, value] of [
+  ["opt_level", "0"],
+  ["debug_assertions", true],
+  ["overflow_checks", true],
+]) {
+  test(`rejects a release-directory executable whose only debug marker is profile.${field}`, () => {
+    const input = fixture();
+    input.messages[1].profile[field] = value;
+    input.jsonLines = input.messages.map((message) => JSON.stringify(message)).join("\n");
+
+    assert.throws(() => build(input), /not built with the release profile/u);
+  });
+}
+
 test("rejects a production binary actually built with the test profile", () => {
   const input = fixture();
   input.messages[1].profile.test = true;
@@ -824,6 +840,29 @@ test("rejects bytes changed after Cargo emitted the authenticated executable", (
   );
 });
 
+test("rejects a same-length rewrite of the authenticated executable", () => {
+  const { input, manifest } = build();
+  // Appending drifts size and digest together, so a size check alone would
+  // still catch it. Flip bytes in place: size, inode and link count are
+  // unchanged and only the digest can expose the rewrite.
+  const executable = input.artifacts[0].executable;
+  const bytes = fs.readFileSync(executable);
+  bytes[0] = bytes[0] === 0 ? 1 : 0;
+  fs.writeFileSync(executable, bytes);
+
+  assert.throws(
+    () =>
+      verifyCargoArtifactManifest({
+        exactSha: SOURCE_SHA,
+        exactTree: SOURCE_TREE,
+        manifest,
+        rustTarget: RUST_TARGET,
+        workspaceRoot: input.root,
+      }),
+    /no longer matches its authenticated build output/u,
+  );
+});
+
 test("rejects a hardlink added after Cargo artifact selection", () => {
   const { input, manifest } = build();
   const alias = path.join(input.root, "cross-graph-cli.exe");

.github/scripts/check-workflow-policy.mjs

@@ -498,14 +498,16 @@ export function retrievalGeneralizationSuitePolicyViolations(
   const expectedFilesystemMemberCounts = {
     existsSync: 1,
     mkdirSync: 7,
-    mkdtempSync: 1,
+    // The hostile matrix owns one tree; the ranker counterexample owns a
+    // second. Both are mkdtempSync under os.tmpdir(), removed on exit.
+    mkdtempSync: 2,
     // Two of these read the shipped pending inventory and the registry document it points at,
     // so the claim-profile ratchet is checked against the tree that ships, not a synthetic one.
-    readFileSync: 6,
+    readFileSync: 5,
     readdirSync: 4,
     readlinkSync: 1,
-    rmSync: 1,
-    writeFileSync: 1,
+    rmSync: 2,
+    writeFileSync: 2,
   };
   const filesystemMemberCounts = new Map();
   for (const name of filesystemMemberReferences) {
@@ -515,8 +517,8 @@ export function retrievalGeneralizationSuitePolicyViolations(
     );
   }
   const fixtureFilesystemShapeIsExact =
-    fsReferenceCount === 24
-    && filesystemMemberReferences.length === 22
+    fsReferenceCount === 26
+    && filesystemMemberReferences.length === 24
     && Object.entries(expectedFilesystemMemberCounts).every(
       ([name, count]) => (filesystemMemberCounts.get(name) ?? 0) === count,
     )
@@ -550,7 +552,7 @@ export function retrievalGeneralizationSuitePolicyViolations(
     && writeFirstArguments.length === writeReferenceCount
     && writeFirstArguments.every((root) => registeredWriteRoots.has(root));
   const fixturePathReferenceShapeIsExact =
-    repositoryRootReferenceCount === 14
+    repositoryRootReferenceCount === 15
     && fixtureRootReferenceCount === 10
     && productionRepositoryRootReferenceCount === 5;
   const protectedRetrievalWorkflow = `.github/workflows/${retrievalFile}`;
@@ -605,8 +607,8 @@ export function retrievalGeneralizationSuitePolicyViolations(
   );
   add(
     violations,
-    invocationCount === 1 && lintReferenceCount === 2,
-    `${retrievalGeneralizationSuiteFile} must execute the hostile fixture matrix through one in-process lint invocation`,
+    invocationCount === 2 && lintReferenceCount === 3,
+    `${retrievalGeneralizationSuiteFile} must execute the hostile matrix and the ranker probes through in-process lint invocations only`,
   );
   add(
     violations,
@@ -635,16 +637,19 @@ export function retrievalGeneralizationSuitePolicyViolations(
     source.includes(
       'fs.mkdtempSync(path.join(os.tmpdir(), "codestory-generalization-"))',
     )
-      && temporaryRootCount === 1
-      && temporaryTreeCount === 1
+      && source.includes(
+        'fs.mkdtempSync(path.join(os.tmpdir(), "ranker-literal-"))',
+      )
+      && temporaryRootCount === 2
+      && temporaryTreeCount === 2
       && source.includes(
         'assert.ok(\n    path.relative(repositoryRoot, fixtureRoot).startsWith(".."),',
       )
       && source.includes("const productionRepositoryRoot = path.join(\n    fixtureRoot,")
       && source.includes("const extraRustRoot = path.join(fixtureRoot,")
       && source.includes("const nonRustRoot = path.join(fixtureRoot,")
       && source.includes("const taskRoot = path.join(fixtureRoot,"),
-    `${retrievalGeneralizationSuiteFile} must keep every mutable hostile fixture under one temporary tree outside the checkout`,
+    `${retrievalGeneralizationSuiteFile} must keep every mutable hostile fixture under its declared temporary trees outside the checkout`,
   );
   add(
     violations,
@@ -667,8 +672,9 @@ export function retrievalGeneralizationSuitePolicyViolations(
   );
   add(
     violations,
-    source.includes("fs.rmSync(fixtureRoot, { recursive: true, force: true });"),
-    `${retrievalGeneralizationSuiteFile} must remove its isolated fixture tree after the matrix`,
+    source.includes("fs.rmSync(fixtureRoot, { recursive: true, force: true });")
+      && source.includes("fs.rmSync(rankerRoot, { recursive: true, force: true });"),
+    `${retrievalGeneralizationSuiteFile} must remove its isolated fixture trees after the matrix`,
   );
   return violations;
 }

.github/scripts/check-workflow-policy.test.mjs

@@ -6045,15 +6045,15 @@ await import("node:worker_threads");
 `, {}, /must not create subprocesses, workers, or clusters/u],
     ["matrix calls the lint twice", `${source}
 runRetrievalGeneralizationLint({});
-`, {}, /through one in-process lint invocation/u],
+`, {}, /through in-process lint invocations/u],
     ["matrix aliases the lint for a second invocation", source.replace(
       "    const result = runRetrievalGeneralizationLint({",
       [
         "    const invokeAgain = runRetrievalGeneralizationLint;",
         "    invokeAgain({});",
         "    const result = runRetrievalGeneralizationLint({",
       ].join("\n"),
-    ), {}, /through one in-process lint invocation/u],
+    ), {}, /through in-process lint invocations/u],
     ["global file lock returns", `${source}
 fs.openSync(path.join(os.tmpdir(), "retrieval-generalization.lock"), "wx");
 `, {}, /must not restore a global or cross-process fixture lock/u],
@@ -6069,15 +6069,15 @@ fs.openSync(path.join(os.tmpdir(), "retrieval-generalization.lock"), "wx");
     ["second global temporary root returns", `${source}
 const sharedRoot = fs.mkdtempSync(path.join(os.tmpdir(), "shared-suite-"));
 fs.mkdirSync(path.join(sharedRoot, "sentinel"));
-`, {}, /under one temporary tree outside the checkout/u],
+`, {}, /declared temporary trees outside the checkout/u],
     ["second sibling temporary root returns", `${source}
 const sharedRoot = fs.mkdtempSync(path.join(path.dirname(fixtureRoot), "shared-suite-"));
 fs.mkdirSync(path.join(sharedRoot, "sentinel"));
-`, {}, /under one temporary tree outside the checkout/u],
+`, {}, /declared temporary trees outside the checkout/u],
     ["fixtures move into the checkout", source.replace(
       'fs.mkdtempSync(path.join(os.tmpdir(), "codestory-generalization-"))',
       'fs.mkdtempSync(path.join(repositoryRoot, "codestory-generalization-"))',
-    ), {}, /under one temporary tree outside the checkout/u],
+    ), {}, /declared temporary trees outside the checkout/u],
     ["checkout read-only comparison is removed", source.replace(
       "const checkoutBefore = treeDigest(repositoryRoot);",
       "const checkoutBefore = null;",
@@ -6110,7 +6110,7 @@ fs.mkdirSync(path.join(sharedRoot, "sentinel"));
     ["fixture cleanup is removed", source.replace(
       "fs.rmSync(fixtureRoot, { recursive: true, force: true });",
       "",
-    ), {}, /remove its isolated fixture tree/u],
+    ), {}, /remove its isolated fixture trees/u],
   ];
 
   for (const [name, candidate, options, expectedReason] of mutations) {

.github/scripts/install-codestory-marketplace-proof.test.mjs

@@ -5,6 +5,7 @@ import {
   mkdtempSync,
   mkdirSync,
   readFileSync,
+  readdirSync,
   realpathSync,
   rmSync,
   writeFileSync,
@@ -89,12 +90,21 @@ test("Windows executes a command shim whose path and arguments contain spaces",
   }
 });
 
-function run(executable, args, options = {}) {
-  const result = spawnSync(executable, args, {
+// Spawning through a shell breaks on spaced executable paths (node.exe under
+// "C:\Program Files\nodejs" dies as 'C:\Program' is not recognized). Route
+// every child through the production planner: real executables spawn
+// directly, only .cmd/.bat shims go through comspec.
+function spawnPlan(executable, args, options = {}) {
+  const { command, commandArgs, spawnOptions = {} } = commandPlan(executable, args);
+  return spawnSync(command, commandArgs, {
     ...options,
+    ...spawnOptions,
     encoding: "utf8",
-    shell: process.platform === "win32",
   });
+}
+
+function run(executable, args, options = {}) {
+  const result = spawnPlan(executable, args, options);
   assert.equal(
     result.status,
     0,
@@ -153,28 +163,46 @@ function proofArgs({
   ];
 }
 
-function assertFailedProof(args, message) {
-  const result = spawnSync(process.execPath, args, {
-    encoding: "utf8",
-    shell: process.platform === "win32",
-  });
+function assertFailedProof(args, message, options = {}) {
+  const result = spawnPlan(process.execPath, args, options);
   assert.notEqual(result.status, 0);
   assert.match(result.stderr, message);
 }
 
 test("pinned Codex installs a local marketplace fixture into the attested cache", () => {
   const root = mkdtempSync(path.join(tmpdir(), "codestory-marketplace-proof-"));
   try {
+    // Every child of this test runs against owned state: an npm cache and a
+    // HOME under the fixture root. Inheriting ambient npm config/cache or the
+    // developer's HOME makes the outcome depend on machine state.
     const packageRoot = path.join(root, "codex-package");
-    const npm = process.platform === "win32" ? "npm.cmd" : "npm";
+    const npmCache = path.join(root, "npm-cache");
+    const personalHome = path.join(root, "personal-home");
+    const childEnv = {
+      ...process.env,
+      HOME: personalHome,
+      USERPROFILE: personalHome,
+      npm_config_cache: npmCache,
+    };
+    // Resolve npm.cmd to an absolute path: commandPlan quotes the command
+    // name, and a quoted bare name leaves cmd's %0 unexpanded, so npm.cmd
+    // would compute %~dp0 (its install prefix) from the cwd.
+    const npm = process.platform === "win32"
+      ? spawnSync("where.exe", ["npm.cmd"], { encoding: "utf8" }).stdout.trim()
+        .split(/\r?\n/u)[0]
+      : "npm";
     run(npm, [
       "install",
       "--prefix",
       packageRoot,
       "--no-audit",
       "--no-fund",
       `@openai/codex@${codexVersion}`,
-    ]);
+    ], { env: childEnv });
+    assert.ok(
+      readdirSync(npmCache).length > 0,
+      "npm install did not use the fixture-owned cache",
+    );
 
     const marketplaceRoot = path.join(root, "marketplace");
     const pluginSourceRoot = path.join(root, "plugin-source");
@@ -209,7 +237,6 @@ test("pinned Codex installs a local marketplace fixture into the attested cache"
     const marketplaceRevision = commitFixture(marketplaceRoot, "fixture", {
       init: true,
     });
-    const personalHome = path.join(root, "personal-home");
     mkdirSync(path.join(personalHome, ".agents", "plugins"), { recursive: true });
     writeFileSync(
       path.join(personalHome, ".agents", "plugins", "marketplace.json"),
@@ -245,12 +272,7 @@ test("pinned Codex installs a local marketplace fixture into the attested cache"
       marketplaceRevision,
       expectedVersion: pluginManifest.version,
       sourceRepository: pluginSourceRoot,
-    }), {
-      env: {
-        ...process.env,
-        HOME: personalHome,
-      },
-    });
+    }), { env: childEnv });
 
     const attestation = JSON.parse(readFileSync(attestationPath));
     const expectedPluginRoot = path.join(
@@ -320,9 +342,7 @@ test("pinned Codex installs a local marketplace fixture into the attested cache"
       "--installation-source",
       "codex_marketplace_restored_fixture",
     );
-    run(process.execPath, restoredArgs, {
-      env: { ...process.env, HOME: personalHome },
-    });
+    run(process.execPath, restoredArgs, { env: childEnv });
     const restoredAttestation = JSON.parse(
       readFileSync(path.join(restoredRoot, "attestation.json")),
     );
@@ -349,6 +369,7 @@ test("pinned Codex installs a local marketplace fixture into the attested cache"
         sourceRepository: pluginSourceRoot,
       }),
       /installed plugin bytes do not match the checked-out CodeStory package/u,
+      { env: childEnv },
     );
     commitFixture(pluginSourceRoot, "change release tree");
     assertFailedProof(
@@ -361,6 +382,7 @@ test("pinned Codex installs a local marketplace fixture into the attested cache"
         sourceRepository: pluginSourceRoot,
       }),
       /pinned marketplace plugin source does not match the release source tree/u,
+      { env: childEnv },
     );
 
     const catalogPath = path.join(
@@ -386,6 +408,7 @@ test("pinned Codex installs a local marketplace fixture into the attested cache"
         sourceRepository: pluginSourceRoot,
       }),
       /marketplace plugin source is not pinned to one immutable commit/u,
+      { env: childEnv },
     );
   } finally {
     rmSync(root, { recursive: true, force: true });