Build the image from the whole tree, not a curated COPY list - #236
Merged
Conversation
The first build of this image failed collecting `tests/test_deployment_docs.py`: the Dockerfile copied `src`, `tests` and `examples`, and the suite reads `docs/DEPLOYMENT.md`. Adding `docs` would have fixed that one test and left the trap. The `test` stage exists to run the repository's own gates in the image that gets deployed, and those gates read the repository — docs, `pyproject.toml` for the wheel build, `README.md`. Any curated list is a build failure waiting for the next test that reads a file nobody remembered. So the context is copied whole and `.dockerignore` names what must stay out: git history, the local virtualenv (wrong platform inside the image), and build caches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first build of the deployment image failed collecting
tests/test_deployment_docs.py— the Dockerfile copiedsrc,testsandexamples, and the suite readsdocs/DEPLOYMENT.md.Adding
docsfixes that one test and leaves the trap in place. Theteststage exists to run the repository's own gates in the image that gets deployed, and those gates read the repository: docs,pyproject.tomlfor the wheel build,README.md. A curated COPY list is a build failure waiting for the next test that reads a file nobody remembered to add.Context is copied whole;
.dockerignorenames what stays out (git history, the local virtualenv — wrong platform inside the image — and build caches).Run that failed: https://github.com/TheDancingDeveloper-org/agent-harness/actions/runs/31241801372