Skip to content

Improve rank_of_matrix with edge case handling and immutability#13088

Closed
Pari658 wants to merge 2 commits intoTheAlgorithms:masterfrom
Pari658:solution/improved_rank_of_matrix
Closed

Improve rank_of_matrix with edge case handling and immutability#13088
Pari658 wants to merge 2 commits intoTheAlgorithms:masterfrom
Pari658:solution/improved_rank_of_matrix

Conversation

@Pari658
Copy link
Copy Markdown

@Pari658 Pari658 commented Oct 2, 2025

Describe your change:

Added support for edge cases like completely empty matrices ([]) and single empty rows ([[]]).
Ensured the original input matrix is not modified by using deepcopy.
Expanded doctests with new cases to verify correctness and immutability.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Oct 2, 2025
@cclauss
Copy link
Copy Markdown
Member

cclauss commented Oct 14, 2025

Closing tests_are_failing PRs to prepare for Hacktoberfest

@cclauss cclauss closed this Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants