Skip to content

Add RBFNN implementation with Iris classification#12793

Closed
quantum-shubham wants to merge 3 commits intoTheAlgorithms:masterfrom
quantum-shubham:rbfnn_shubham
Closed

Add RBFNN implementation with Iris classification#12793
quantum-shubham wants to merge 3 commits intoTheAlgorithms:masterfrom
quantum-shubham:rbfnn_shubham

Conversation

@quantum-shubham
Copy link
Copy Markdown

Describe your change:

Add RBFNN implementation with Iris classification

@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Jun 15, 2025
@algorithms-keeper algorithms-keeper Bot added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Jun 15, 2025
Copy link
Copy Markdown

@algorithms-keeper algorithms-keeper Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment thread neural_network/rbfnn.py
Comment thread neural_network/rbfnn.py
Comment thread neural_network/rbfnn.py
Comment thread neural_network/rbfnn.py
# Step 3: Solve output weights using least squares
self.weights = np.linalg.pinv(rbf_activations).dot(y_data)

def predict(self, x):
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file neural_network/rbfnn.py, please provide doctest for the function predict

Please provide return type hint for the function: predict. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide descriptive name for the parameter: x

Please provide type hint for the parameter: x

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Jun 15, 2025
@algorithms-keeper algorithms-keeper Bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Jun 15, 2025
@quantum-shubham
Copy link
Copy Markdown
Author

This PR introduces a clean implementation of a Radial Basis Function Neural Network (RBFNN) for classification, demonstrated on the Iris dataset.

Key Features:

Gaussian RBF activation in the hidden layer.

KMeans clustering for center initialization.

Least-squares fitting for training output weights.

Do tell, if you'd like enhancements such as regularization, cross-validation, or multi-dataset support as well!

@cclauss
Copy link
Copy Markdown
Member

cclauss commented Oct 14, 2025

Closing require_descriptive_names PRs to prepare for Hacktoberfest

@cclauss cclauss closed this Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants