fix: remove duplicate VEGAS DX wrapper entry + feat: add delete, local install, progress bar to VEGAS config dialog#84
Open
isygold wants to merge 3 commits into
Open
fix: remove duplicate VEGAS DX wrapper entry + feat: add delete, local install, progress bar to VEGAS config dialog#84isygold wants to merge 3 commits into
isygold wants to merge 3 commits into
Conversation
Remove standalone VEGAS option, keep only VEGAS+VKD3D which includes VKD3D for DirectX 12 support alongside VEGAS for D3D9/10/11.
…cations (#1) * feat(ui): add delete, local file picker, and progress bar to VEGAS config dialog with user notifications * fix: use direct profile iteration instead of getProfileByEntryName which misparses vegas- prefix * fix: null-safety on findActivity() return value
isygold
changed the title
… progress bar in VegasDownloadSheet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes to the VEGAS+VKD3D configuration in the DX wrapper system:
1. Removed duplicate standalone VEGAS DX wrapper entry
app/src/main/res/values/arrays.xml: Removed the plainVEGASentry fromdxwrapper_entries. BothVEGASandVEGAS+VKD3Dhit the samecontains("vegas")branch inXServerDisplayActivity.java:1835, so standalone VEGAS was identical to VEGAS+VKD3D. OnlyVEGAS+VKD3Dremains.2. New UI elements for VEGAS+VKD3D config dialog
app/src/main/java/com/winlator/star/ui/screens/ContainerDetailScreen.kt(+98 lines):Files Changed
app/src/main/res/values/arrays.xmlapp/src/main/java/com/winlator/star/ui/screens/ContainerDetailScreen.ktError Messages