Skip to content

updates peers list - #9

Draft
tomjemmett wants to merge 2 commits into
mainfrom
update_peers
Draft

updates peers list#9
tomjemmett wants to merge 2 commits into
mainfrom
update_peers

Conversation

@tomjemmett

Copy link
Copy Markdown
Member
  • uses peers list from model health system
  • for specialist providers that aren't in that list have been added in 3 groups (womens and childrens, orthopaedic and neurology, other specialist)
  • the remaining two providers (UHB, Croydon) used the older peers

- uses peers list from model health system
- for specialist providers that aren't in that list have been added in 3 groups (womens and childrens, orthopaedic and neurology, other specialist)
- the remaining two providers (UHB, Croydon) used the older peers
Copilot AI review requested due to automatic review settings July 22, 2026 13:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates how the app determines and displays provider peer groups by switching from an internal RDS peers dataset to a JSON peers mapping (aligned to the model health system), and adjusting server-side peer selection logic accordingly.

Changes:

  • Replace peers.Rds loading with inst/peers.json loading via yyjsonr::read_json_file().
  • Simplify peer selection to a direct %in% filter on org_id using the selected provider and its peer list.
  • Adjust peer ID extraction sent to the front-end map handler.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
R/app_server.R Loads peers from JSON and updates the peer-selection/filtering + peer ID extraction logic.
inst/peers.json Adds the new peers mapping data used by the server for peer selection.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread R/app_server.R Outdated
Comment thread R/app_server.R Outdated
@tomjemmett
tomjemmett requested a review from DCEW August 6, 2026 15:21
@tomjemmett
tomjemmett marked this pull request as draft August 6, 2026 15:45
@DCEW

DCEW commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

I'm checking again with @AlisonJaneWright and dev board whether we can go ahead and make this change. I've sent her an excel file that shows, particularly for active schemes, how the incoming OMHS peers would change their list of peers. We should not merge this until Alison and dev board have signed off to give it the go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants