fixes the appearance of the start button - #16
Open
tomjemmett wants to merge 2 commits into
Open
Conversation
if the browser was resized the start button can exhibit strange behaviour. this change makes the button sit inside its own div and then be right aligned. this prevents the button from filling the whole width of the container
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Shiny UI layout so the dynamically-rendered “Start” button stays right-aligned and doesn’t behave oddly (or appear to stretch) after browser resize events.
Changes:
- Wraps the
start_buttonuiOutput()in a right-aligned container in the UI. - Simplifies the server-side
start_buttonrendering by removing thebslib::layout_columns()wrapper and returning only the<a>button element.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| R/app_ui.R | Wraps uiOutput("start_button") in a right-aligned div to control layout on resize. |
| R/app_server.R | Removes layout_columns() around the Start link so the UI can handle alignment without column hacks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if the browser was resized the start button can exhibit strange behaviour. this change makes the button sit inside its own div and then be right aligned. this prevents the button from filling the whole width of the container