Skip to content

use progress app - #13

Open
tomjemmett wants to merge 3 commits into
mainfrom
use_progress_app
Open

use progress app#13
tomjemmett wants to merge 3 commits into
mainfrom
use_progress_app

Conversation

@tomjemmett

Copy link
Copy Markdown
Member
  • redirect the user to the progress app if a scenario has previously been submitted
  • if we are creating a new scenario, we must remove the inputs_app metadata

Copilot AI lite review requested due to automatic review settings August 10, 2026 14:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the scenario “Start” flow to (1) redirect users to the model-run progress application when an existing scenario has already been submitted and has a stored model run ID, and (2) remove __inputs_app__ metadata when creating a new scenario from an existing one to avoid carrying over inputs-app metadata.

Changes:

  • Add conditional redirect to the model-run progress app when editing an existing scenario that includes __inputs_app__.model_run_id.
  • Remove __inputs_app__ metadata when creating a new scenario from an existing scenario before writing params JSON for the inputs app.
  • Add model_run_progress_url configuration entries for default/development/production.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
R/app_server.R Adds “View Progress” redirect logic and clears __inputs_app__ metadata for “Create new from existing” before launching the inputs app.
inst/config.yml Introduces model_run_progress_url per environment to support progress app redirection.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread R/app_server.R
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants