Sta update latest 0505

[openroad-ci]

Weekly upstream pull 05/05 has fix for one parallaxsw/OpenSTA#429 and another memory leak

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dsengupta0628
❌ jjcherry56
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[gemini-code-assist]

Code Review

This pull request introduces support for a -mode argument in the write_sdc command and refactors the Sta class to track the current mode independently of the command scene. Review feedback highlights a critical bug in VerilogWriter.cc where C-style strings are compared by address rather than content, and a potential logic error in Sdc.tcl where a pointer is used instead of a mode name. Additionally, the removal of an empty string check in setCmdMode and a typo in the documentation example should be addressed.

[gemini-code-assist]

This condition compares two const char* pointers using !=, which compares their memory addresses instead of their string content. This is a bug. The previous implementation used !stringEqual(...), which was likely correct. You should use a proper string comparison method, such as strcmp or by converting the C-style strings to std::string before comparison.

          && std::string(network_->name(port)) != std::string(network_->name(net))) {

[dsengupta0628]

Hallucination: Both Network::name(Port*) and Network::name(Net*) return std::string, not const char*. operator!= on std::string does content comparison. No bug

[gemini-code-assist]

There is a potential bug in how the mode variable is being set. The [cmd_mode] command returns a Mode* object, not the mode's name as a string. When this object is passed to write_sdc_cmd, it will likely be converted to a string representation of the pointer, causing findMode in the C++ code to fail when no -mode is specified. You should use [cmd_mode_name] to retrieve the name of the current mode.

  set mode [cmd_mode_name]
  if { [info exists keys(-mode)] } {
    set mode $keys(-mode)
  }

[dsengupta0628]

Search.i:822 cmd_mode() returns Mode* (SWIG pointer string _xxx_p_Mode).
Sdc.i:96 write_sdc_cmd expects std::string mode_name.
Line 72 set mode [cmd_mode] passes pointer string to wrapper expecting mode name --> findMode fails.

Line 48 already uses [cmd_mode_name] for prev_mode. Same pattern needed in line 72

[dsengupta0628]

Ignore

[gemini-code-assist]

The check for an empty mode_name has been removed from this function. The previous implementation had a check if (!mode_name.empty()). Without it, calling setCmdMode with an empty string could lead to a Mode with an empty name being created, which might result in an invalid state or unexpected behavior. It would be safer to restore a check for an empty mode_name at the beginning of the function.

[dsengupta0628]

Commit f622da7 removed if (!mode_name.empty()) guard. Now empty mode_name:

• findKey miss (no "" entry)
• Falls to else branch → new Mode("", ...) registered in map
• Invalid Mode with empty name lingers

Fix: guard early in function:

void
 Sta::setCmdMode(std::string_view mode_name)
 {
   if (mode_name.empty())
     return;
   Mode *mode = findKey(mode_name_map_, std::string(mode_name));
   ...

Or report_->error(...) instead of silent return.

[dsengupta0628]

Ignore

[gemini-code-assist]

There appears to be a typo in the example provided. The note is about the write_sdc command, but the example shows read_sdc. To avoid confusion, the example should probably be for write_sdc.

  write_sdc [-mode mode]

[dsengupta0628]

fixed

[dsengupta0628]

parallaxsw/OpenSTA#432

[dsengupta0628]

OpenROAD compilation will not succeed as we need the change in src/dbSta/CMakeLists.txt to update ${OPENSTA_HOME}/tcl/Variables.tcl to ${OPENSTA_HOME}/sdc/Variables.tcl as this file has been moved in OpenSTA to sdc/ from tcl/

[dsengupta0628]

secure CI http://secure-ci:8080/view/My/job/SB/job/secure-or_update_sta_0506/