Sta update latest 0427

[openroad-ci]

Merge latest upstream OSTA, update test infrastructure

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ dsengupta0628
❌ jjcherry56
❌ calewis
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[gemini-code-assist]

Code Review

This pull request introduces several refactorings and improvements to the OpenSTA codebase, including transitioning clock uncertainties from pointers to member objects, updating .clang-tidy configurations, and centralizing delay reporting within the Search class. It also adds a validation check for POCV/LVF models and refines SPEF lexing for identifiers. The review feedback points out critical compilation issues in Sta.hh due to missing includes and type aliases, identifies a recurring typo in the checkLibraryPocv function name, and suggests a logic improvement to avoid false-positive warnings when no libraries are loaded.

[gemini-code-assist]

The header Sta.hh still uses PathDelayFunc (which is a std::function) in its member function declarations (e.g., line 1531), so the <functional> include is required. Additionally, DelaysWrtClks is now used in this header, so the <map> include is necessary.

#include <functional>
#include <map>

[gemini-code-assist]

The PathDelayFunc and DelaysWrtClks type aliases are used in this header but are no longer defined here. They should be restored or the header that defines them must be included to ensure Sta.hh remains self-contained and compilable.

// Path::slack/arrival/required function.
using PathDelayFunc = std::function<Delay (const Path *path)>;
using DelaysWrtClks = std::map<const ClockEdge*, RiseFallMinMaxDelay>;
using GraphLoopSeq = std::vector<GraphLoop*>;

[dsengupta0628]

This header is in src/sta/, an upstream submodule, and we don't modify upstream files unless necessary

[gemini-code-assist]

Typo in function name: checkLibrarayPocv should be checkLibraryPocv.

  void checkLibraryPocv();

[gemini-code-assist]

Typo in function call: checkLibrarayPocv should be checkLibraryPocv.

      checkLibraryPocv();

[gemini-code-assist]

Typo in function call: checkLibrarayPocv should be checkLibraryPocv.

      checkLibraryPocv();

[gemini-code-assist]

There is a typo in the function name (checkLibrarayPocv -> checkLibraryPocv). Additionally, the warning logic should be updated to avoid reporting 'No liberty POCV/LVF models found' when no libraries have been loaded yet, as this leads to false positives if the mode is set early in a script.

void
Sta::checkLibraryPocv()
{
  bool any_lib = false;
  LibertyLibraryIterator *lib_iter = network_->libertyLibraryIterator();
  while (lib_iter->hasNext()) {
    any_lib = true;
    LibertyLibrary *lib = lib_iter->next();
    LibertyCellIterator cell_iter(lib);
    while (cell_iter.hasNext()) {
      LibertyCell *cell = cell_iter.next();
      for (const TimingArcSet *arc_set : cell->timingArcSets()) {
        for (const TimingArc *arc : arc_set->arcs()) {
          GateTableModel *gate_model = arc->gateTableModel();
          if (gate_model) {
            const TableModels *models = gate_model->delayModels();
            if (models->sigma(EarlyLate::early()) != nullptr) {
              delete lib_iter;
              return;
            }
          }
        }
      }
    }
  }
  delete lib_iter;
  if (any_lib)
    report_->warn(1578, "No liberty POCV/LVF models found.");
}