test: actually report the failure in the log#10608
Merged
maliberty merged 1 commit intoJun 8, 2026
Merged
Conversation
Signed-off-by: Peter Gadfort <peter.gadfort@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request standardizes indentation to spaces in test/regression_test.sh and improves error handling by ensuring the script exits with a non-zero status and prints an error message when log diffs or pass/fail checks fail. The review feedback suggests enhancing debuggability in CI environments by printing the actual diff (using diff -u) and the last few lines of the log file directly to standard output upon failure.
maliberty
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Print the reason of the test failure, the diff is not particularly clear when the failure is a missing newline.
Type of Change
Impact
None, just improve feedback on tests.
Verification
./etc/Build.sh).