Skip to content

test: actually report the failure in the log#10608

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
gadfort:test-better-log-info
Jun 8, 2026
Merged

test: actually report the failure in the log#10608
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
gadfort:test-better-log-info

Conversation

@gadfort

@gadfort gadfort commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Print the reason of the test failure, the diff is not particularly clear when the failure is a missing newline.

Type of Change

  • New feature

Impact

None, just improve feedback on tests.

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have signed my commits (DCO).

Signed-off-by: Peter Gadfort <peter.gadfort@gmail.com>
@gadfort gadfort requested a review from a team as a code owner June 7, 2026 20:04
@gadfort gadfort requested a review from osamahammad21 June 7, 2026 20:04
@github-actions github-actions Bot added the size/S label Jun 7, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes indentation to spaces in test/regression_test.sh and improves error handling by ensuring the script exits with a non-zero status and prints an error message when log diffs or pass/fail checks fail. The review feedback suggests enhancing debuggability in CI environments by printing the actual diff (using diff -u) and the last few lines of the log file directly to standard output upon failure.

Comment thread test/regression_test.sh
Comment thread test/regression_test.sh
@maliberty maliberty merged commit a18be6b into The-OpenROAD-Project:master Jun 8, 2026
17 checks passed
@gadfort gadfort deleted the test-better-log-info branch June 8, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants