Skip to content

The BAZEL_BUILD macro is used in source; explicitly define in BUILD#10607

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
hzeller:feature-20260607-explicit-define
Jun 7, 2026
Merged

The BAZEL_BUILD macro is used in source; explicitly define in BUILD#10607
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
hzeller:feature-20260607-explicit-define

Conversation

@hzeller

@hzeller hzeller commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

Right now, this is only defined in the global .bazelrc, but that file is not inspected if OpenROAD is used as submodule or dependency. So we need to define all the relevant macros in the relevant BUILD rules.

Right now, this is only defined in the global `.bazelrc`, but that file is
not inspected if OpenROAD is used as submodule or dependency. So we need
to define all the relevant macros in the relevant BUILD rules.

Signed-off-by: Henner Zeller <h.zeller@acm.org>
@hzeller hzeller requested a review from a team as a code owner June 7, 2026 18:33
@hzeller hzeller requested a review from jhkim-pii June 7, 2026 18:33

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the BAZEL_BUILD preprocessor definition to the cc_library target in src/tst/BUILD. There are no review comments, and I have no feedback to provide.

@maliberty maliberty merged commit 8c30da4 into The-OpenROAD-Project:master Jun 7, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants