Skip to content

gui/web: use random colors on backside layers to preserve color order on frontside metals#10604

Merged
maliberty merged 2 commits into
The-OpenROAD-Project:masterfrom
gadfort:colors-backside
Jun 7, 2026
Merged

gui/web: use random colors on backside layers to preserve color order on frontside metals#10604
maliberty merged 2 commits into
The-OpenROAD-Project:masterfrom
gadfort:colors-backside

Conversation

@gadfort

@gadfort gadfort commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Ensures the color order for routing layers stays consistent for techs with backside metals.

Type of Change

  • Bug fix?

Impact

No impact

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have included tests to prevent regressions.
  • I have signed my commits (DCO).

… on frontside metals

Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
@gadfort gadfort requested review from a team as code owners June 7, 2026 14:15
@gadfort gadfort requested a review from maliberty June 7, 2026 14:15
@github-actions github-actions Bot added the size/M label Jun 7, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the layer color assignment logic in both the GUI (displayControls.cpp) and the web tile generator (tile_generator.cpp) to ensure that backside layers are assigned random colors and do not consume the standard frontside palette colors. A unit test was also added to verify this behavior. The reviewer suggested refactoring the test setup to use a loop with safety checks when retrieving layers, preventing potential segmentation faults if any layer is missing.

Comment thread src/web/test/cpp/TestTileGenerator.cpp Outdated
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
@gadfort

gadfort commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

@mguthaus FYI

@maliberty maliberty merged commit f289e91 into The-OpenROAD-Project:master Jun 7, 2026
16 checks passed
@gadfort gadfort deleted the colors-backside branch June 7, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants