gui/web: use random colors on backside layers to preserve color order on frontside metals#10604
Merged
Merged
Conversation
… on frontside metals Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the layer color assignment logic in both the GUI (displayControls.cpp) and the web tile generator (tile_generator.cpp) to ensure that backside layers are assigned random colors and do not consume the standard frontside palette colors. A unit test was also added to verify this behavior. The reviewer suggested refactoring the test setup to use a loop with safety checks when retrieving layers, preventing potential segmentation faults if any layer is missing.
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Contributor
Author
|
@mguthaus FYI |
maliberty
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensures the color order for routing layers stays consistent for techs with backside metals.
Type of Change
Impact
No impact
Verification
./etc/Build.sh).