Access Points Know Neighbours#10545
Conversation
Signed-off-by: bnmfw <bernardoborgessandoval@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces tracking for compatible neighbors on access points (frAccessPoint) and refactors access point retrieval in FlexPA by introducing a helper method DPNodeToAccessPoint. Feedback is provided regarding a typo in the newly added method resetCompatibleNeigbours (missing 'h' in 'Neighbours') and its corresponding call site.
| } | ||
| void setAllowVia(bool in) { allow_via_ = in; } | ||
| void addCompatibleNeighbour() { compatible_neighbors_++; } | ||
| void resetCompatibleNeigbours() { compatible_neighbors_ = 0; } |
There was a problem hiding this comment.
There is a typo in the method name resetCompatibleNeigbours (missing 'h' in 'Neighbours'). It should be renamed to resetCompatibleNeighbours to be consistent with addCompatibleNeighbour and getCompatibleNeighbours.
| void resetCompatibleNeigbours() { compatible_neighbors_ = 0; } | |
| void resetCompatibleNeighbours() { compatible_neighbors_ = 0; } |
| nodes[pin_idx][ap_idx] = std::make_unique<FlexDPNode>(); | ||
| nodes[pin_idx][ap_idx]->setIdx({pin_idx, ap_idx}); | ||
| nodes[pin_idx][ap_idx]->setNodeCost(ap->getCost()); | ||
| ap->resetCompatibleNeigbours(); |
There was a problem hiding this comment.
Update the call to use the corrected method name resetCompatibleNeighbours to fix the typo.
| ap->resetCompatibleNeigbours(); | |
| ap->resetCompatibleNeighbours(); |
Signed-off-by: bnmfw <bernardoborgessandoval@gmail.com>
2 participants
Summary
Supports issue #9948. Access points now have the
compatible_neighbors_which represents the number of access points on neighboring pins they are compatible with. This variable is only changed on the first iteration of access pattern creation where the compatibility graph is raw without the any access points marked as used. This PR does not change tool behaviour, only make so this new variable exists and has the correct valueAlso creates the helper
DPNodeToAccessPointfunction that is used on the new feature.Type of Change
Impact
Does not impact tool behavior
Verification
./etc/Build.sh).Related Issues
issue #9948