Skip to content

fix(ci): restore HF dataset download in docker-eval job#294

Merged
luarss merged 1 commit into
The-OpenROAD-Project:masterfrom
luarss:fix/hf-dataset-download
Jun 6, 2026
Merged

fix(ci): restore HF dataset download in docker-eval job#294
luarss merged 1 commit into
The-OpenROAD-Project:masterfrom
luarss:fix/hf-dataset-download

Conversation

@luarss
Copy link
Copy Markdown
Collaborator

@luarss luarss commented Jun 6, 2026

Summary

  • The huggingface-cli download command was accidentally dropped from the Download HF dataset step when ci: parallelise secret CI, cache HF dataset, speed up docker build #291 parallelised the secret CI
  • Without it, a cold runner cache left ./data empty; the Docker container started with no data, the backend never became ready, and the Wait for graph readiness step ran its full 3600 s timeout on every run
  • This restores the download so the cache-miss path actually fetches the dataset

Test plan

  • Verify secret CI completes in expected time on next push to master
  • Confirm cached runs still skip the download (Dataset already cached on runner, skipping download)

The huggingface-cli download command was accidentally dropped when
parallelising the secret CI. Without it, a cold runner cache left
./data empty, the backend never became ready, and the readiness poll
ran its full 3600 s timeout on every run.

Signed-off-by: Jack Luar <jluar@precisioninno.com>
@luarss luarss merged commit adec4dc into The-OpenROAD-Project:master Jun 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant