Fix KeyError and color blending crash on custom TextAreas#6595
Open
amanparab1 wants to merge 1 commit into
Open
Fix KeyError and color blending crash on custom TextAreas#6595amanparab1 wants to merge 1 commit into
amanparab1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request resolves two crashes associated with the
TextAreawidget:apply_css: Mounting or rendering a customTextAreasubclass with overridden or emptyCOMPONENT_CLASSESraisedKeyError: "No 'text-area--gutter' key in COMPONENT_CLASSES". This happened becauseTextAreaTheme.apply_csscalledget_component_rich_style()directly without safety checks. This is resolved by wrapping style retrieval in a try-except block to returnNoneon missing classes rather than crashing.app_theme.primary(a string) was passed directly tobackground_color.blend(), which expects aColorobject, raisingAttributeError: 'str' object has no attribute 'auto'. This is fixed by wrapping the string inColor.parse().Fixes
Fixes #6528
Verification
Added a unit test under
tests/text_area/test_issue_6528.pythat verifiesTextAreasubclassing with overridden component classes mounts and resolves styles correctly without crashes.