Fix issues #3820 expand=False didn't work when it contains Columns#3823
Open
Stranger-Jie wants to merge 3 commits into
Open
Fix issues #3820 expand=False didn't work when it contains Columns#3823Stranger-Jie wants to merge 3 commits into
Stranger-Jie wants to merge 3 commits into
Conversation
Member
|
Can you please add a test for this. |
Author
|
Thanks for the review! I've gone ahead and added a test for this change. Let me know if there's anything else. |
|
This patch works ! Here is a test: 
Please merge this request ! Thank you ! |
2 tasks
Author
|
I've updated the relevant code to fix the bug @willmcgugan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
#3820 , This is a simple fix that adds a method similar to the
__rich_measure__in Panel toConlumnsclass.