Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for showing macOS’s default System Services inside TextGrabber2’s status-bar “Services” submenu by temporarily hosting the current text in an off-screen key window so AppKit can populate NSApp.servicesMenu via the responder chain.
Changes:
- Introduces
ServicesHost(off-screen keyNSPanel+NSTextView) to provide a responder chain for system Services. - Adds a “System Services” submenu entry and wires
NSApp.servicesMenuto it. - Hooks
NSMenuDelegateopen/close events to activate/deactivate the host and propagate return-type service results back to the pasteboard.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| TextGrabber2/Sources/ServicesHost.swift | Adds an off-screen key window/text view host to enable AppKit Services population. |
| TextGrabber2/Sources/Resources.swift | Adds a localized string constant for the “System Services” menu title. |
| TextGrabber2/Sources/App/App+Services.swift | Sets NSApp.servicesMenu to the “System Services” submenu before rebuilding custom service items. |
| TextGrabber2/Sources/App/App+Menu.swift | Activates the host when the Services menu opens and deactivates it when it closes. |
| TextGrabber2/Sources/App/App.swift | Adds servicesHost and inserts the “System Services” submenu placeholder into the Services menu. |
| TextGrabber2/Resources/Localizable.xcstrings | Adds translations for the new “System Services” menu string. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.