Repository navigation
Conversation
PR Summary by QodoAlign PRU I2S builds with shared rules and relocated sources
AI Description
Diagram
High-Level Assessment
Files changed (49)
|
Code Review by QodoView low (2)
1. New library makefile lacks a file header
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
929475c to
ba6662c
Compare
ba6662c to
8d57a17
Compare
8d57a17 to
9e5d826
Compare
de67ca4 to
25b3ade
Compare
25b3ade to
b178148
Compare
b178148 to
26cdfea
Compare
03abdf5 to
086e0fc
Compare
- Move driver (pru_i2s_drv.c/h, pru_i2s_config.h) to source/i2s/ and add source/i2s/makefile with all/clean targets - Rewrite 8 per-core firmware makefiles to use pru_rules.mak (PRU_VERSION=3, outputs in ti-pru-cgt/generated/) - Update example.projectspec files: -v4 -> -v3 - Add firmware/I2S/generated/ and firmware/TDM4/generated/ for array header outputs; update app include paths accordingly - Restructure top-level makefile: guard pru/host inside BUILD_PROJECT check, all: calls - Update README to reflect new directory structure and build flow Signed-off by Ayushman a-ayushman@ti.com
086e0fc to
4bb2203
Compare
| @@ -36,7 +36,7 @@ | |||
| -I${OPEN_PRU_PATH}/examples/pru_i2s/firmware/I2S | |||
| -DPRU0 | |||
| -DSLICE0 | |||
| -v4 | |||
There was a problem hiding this comment.
Review if v4 is correct or v3
| @@ -52,7 +52,7 @@ | |||
| " | |||
|
|
|||
| postBuildStep=" | |||
| $(CG_TOOL_ROOT)/bin/hexpru --diag_wrap=off --array --array:name_prefix=pru_prupru_i2s0_image_0 -o pru_i2s_pru0_array.h pru_i2s_pru0_array_am261x-lp_icssm0-pru0_fw_ti-pru-cgt.out;if ${CCS_HOST_OS} == linux cat ${OPEN_PRU_PATH}/source/firmware/pru_load_bin_copyright.h pru_i2s_pru0_array.h > ${OPEN_PRU_PATH}/examples/pru_i2s/firmware/I2S/pru_i2s_pru0_array.h;if ${CCS_HOST_OS} == linux rm pru_i2s_pru0_array.h;if ${CCS_HOST_OS} == win32 $(CCS_INSTALL_DIR)/utils/cygwin/cat ${OPEN_PRU_PATH}/source/firmware/pru_load_bin_copyright.h pru_i2s_pru0_array.h > ${OPEN_PRU_PATH}/examples/pru_i2s/firmware/I2S/pru_i2s_pru0_array.h;if ${CCS_HOST_OS} == win32 $(CCS_INSTALL_DIR)/utils/cygwin/rm pru_i2s_pru0_array.h; | |||
| $(CG_TOOL_ROOT)/bin/hexpru --diag_wrap=off --array --array:name_prefix=pru_prupru_i2s0_image_0 -o ../pru_i2s_pru0_array.h pru_i2s_pru0_array_am261x-lp_icssm0-pru0_fw_ti-pru-cgt.out | |||
There was a problem hiding this comment.
Is build test done on Windows and Linux both?
There was a problem hiding this comment.
the github workflow is linux based and my setup is windows based, builds on both
| -ldrivers.am261x.r5f.ti-arm-clang.freertos.release.lib | ||
| -lboard.am261x.r5f.ti-arm-clang.freertos.release.lib | ||
| -lpru_i2s.am261x.r5f.ti-arm-clang.release.lib | ||
| -lpru_i2s.am261x.r5f.ti-arm-clang.Release.lib |
There was a problem hiding this comment.
Isn't "release" correct?
There was a problem hiding this comment.
the library is produced with .Release and .Debug, so aligned with that
| ├── makefile # Top-level makefile | ||
| ├── firmware/ # PRU firmware source code | ||
| │ ├── include/ # Shared firmware headers | ||
| │ ├── I2S/ # I2S protocol implementation |
There was a problem hiding this comment.
Why are we using capital case I2S and TDM4 in folder names here? Any specific reason?
There was a problem hiding this comment.
No specific reason, it was there in the original code as well so stuck to that,
will change to lowercase i2s/tdm4
signed-off by Ayushman <a-ayushman@ti.com>
927c981 to
9c07d16
Compare
9c07d16 to
5425d92
Compare
signed-off by Ayushman <a-ayushman@ti.com>
5425d92 to
66402dc
Compare
Signed-off by Ayushman a-ayushman@ti.com