fix(homebridge-teslemetry): correct version baseline for the major hard-cut bump#65
Merged
Merged
Conversation
…rd-cut bump package.json was hand-bumped to 1.0.0 in #63 while also carrying a "major" changeset. Changesets' major bump increments from whatever is currently in package.json, so merging the auto-generated Version Packages PR would have shipped 2.0.0, not the intended 1.0.0 landing over legacy 0.4.6. Reverting to the pre-cut 0.1.11 baseline lets the existing changeset resolve to 1.0.0 as originally intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
homebridge-teslemetry,private: truedropped, migration-notes changeset) but hand-bumpedpackage.json'sversionto1.0.0in addition to adding amajorchangeset.package.json, not from the legacy npm baseline. With version already at1.0.0, the auto-generated Version Packages PR (chore: version packages #64) resolves themajorbump to 2.0.0, not the intended1.0.0landing over legacy0.4.6.versionto the pre-cut0.1.11baseline so the existing changeset's major bump resolves to1.0.0as originally intended. The changeset itself (name, migration notes,majorbump type) is unchanged - it was correct, only the manual version edit conflicted with it.1.0.0once this merges and the changesets bot re-runs, but if it was already reviewed/approved at2.0.0it should be re-checked before merging. Merging chore: version packages #64 is what actually triggers the npm publish - not this PR.pnpm --filter homebridge-teslemetry build,tsc, andtest(90/90) all pass,pnpm lintis clean, andnpm pack --dry-runproduces a correct 5-file tarball (dist/,config.schema.json,README.md,package.json).