command: fill in the CarServer.Response reply-payload oneof#10
Merged
Conversation
Response.response_msg stopped modelling the server reply surface at
field 9 (plus field 15, added separately), so every other server->app
reply silently decoded to just {actionStatus}. Add the reply oneof
entries and their message trees for StreamMessage,
VehicleDataSubscriptionResponse, VitalsSubscriptionResponse,
PiiKeyResponse, PseudonymSyncResponse, NavigationRouteResponse,
GetManagedChargingSitesResponse, AddManagedChargingSiteResponse,
GetMessagesResponse, GetLocalProfilesResponse, KeysInfoResponse and
BandwidthTestResponse, based on our own observations and
contributions from the community.
Field 12 (GetRateTariffResponse) is left out: its only field is a
rate-tariff type from an app-only namespace this package doesn't
publish, so it needs a namespace-publish decision first. Fields 17
and 19 stay excluded as documented app-only namespaces.
This was referenced Jul 22, 2026
Bre77
added a commit
that referenced
this pull request
Jul 22, 2026
Field 12 was left reserved in #10 pending a decision on whether to publish a rate-tariff type from an app-only namespace this package doesn't otherwise model. The captain decided to publish: the same tariff document is already writable via SetRateTariffRequest (tag 55) and readable via GetRateTariffRequest (tag 56), so the read reply is worth modelling too. Model GetRateTariffResponse by mirroring the tariff document already declared for SetRateTariffRequest (Seasons/Tariff at tags 13/14), based on our own observations and contributions from the community, rather than re-declaring a separate namespace for a single reused document shape. Un-reserving field 12 trips buf's RESERVED_MESSAGE_NO_DELETE breaking check even though it's a wire-compatible addition, so except it repo-wide in buf.yaml - the same fields-17/19 follow-up will hit it too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Response.response_msgstopped modelling the server reply surface at field 9 (plus field 15, added in command: add GetChargeOnSolarFeatureResponse reply schema #6), so every other server->app reply silently decoded to just{actionStatus}with its real payload dropped.StreamMessage(4),VehicleDataSubscriptionResponse(6),VitalsSubscriptionResponse(8),PiiKeyResponse(10),PseudonymSyncResponse(11),NavigationRouteResponse(13, +TrafficDetail/TrafficStatus),GetManagedChargingSitesResponse(14),AddManagedChargingSiteResponse(16),GetMessagesResponse(18),GetLocalProfilesResponse(20),KeysInfoResponse(24) andBandwidthTestResponse(25), based on our own observations and contributions from the community. Reuses existing messages (StreamMessage,ManagedChargingSite,PiiKeyRequest's sibling types) where the package already had them.TESLEMETRY-EXTper the usual convention; the new message tree sits in a single fenced block.unknown/unknown_Nplaceholder rather than a guessed name, keeping their number and type intact so they still round-trip.GetRateTariffResponse) is deliberately left out: its only field is a rate-tariff type from an app-only namespace this package doesn't publish, so it needs a namespace-publish decision first, same as the already-excluded fields 17 (centerdisplay.server) and 19 (webrtc_comms).buf lint, andbuf breakingare all green.