feat(vehicle): add niche low-certainty-value signed commands#96
Merged
Conversation
Wraps the remaining five VehicleAction fields with no known third-party consumer use case today: pii_key_request, pseudonym_sync_request, tesla_auth_response, setup_cloud_profile_with_local_profile_uuid, and get_local_profiles_for_vault_uuid. Included per the captain's full-proto-coverage directive; low-certainty value, easy to drop if reconsidered later since each is purely additive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
VehicleActionfields with no known third-party consumer use case today:pii_key_request,pseudonym_sync_request(privacy/telemetry pseudonymization internals),tesla_auth_response(pass-through for a vehicle-screen "Sign in with Tesla" OAuth response the caller must already have from elsewhere),setup_cloud_profile_with_local_profile_uuid,get_local_profiles_for_vault_uuid(undocumented Tesla profile-vault sync).VehicleActionproto surface, not because any consumer (including this library's own Teslemetry/Tessie/HA lineage) has asked for them - easy to hold back from this PR alone if reconsidered, since each is independent and purely additive.tests/test_ble_niche_commands.pycover each command's built signed message over the mocked BLE transport.